Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 1100003005: ServiceWorker: Cleanup ServiceWorkerVersion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index 11810a89c94b6104b2447cd2828e68f441708184..70f7167d7910a5cc2ed76d8a16566b91dab3d9b0 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -313,11 +313,11 @@ class CONTENT_EXPORT ServiceWorkerVersion
private:
friend class base::RefCounted<ServiceWorkerVersion>;
friend class ServiceWorkerURLRequestJobTest;
+ friend class ServiceWorkerVersionBrowserTest;
+
FRIEND_TEST_ALL_PREFIXES(ServiceWorkerControlleeRequestHandlerTest,
ActivateWaitingVersion);
FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, IdleTimeout);
- FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, KeepAlive);
- FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, ListenerAvailability);
FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, SetDevToolsAttached);
FRIEND_TEST_ALL_PREFIXES(ServiceWorkerWaitForeverInFetchTest, RequestTimeout);
FRIEND_TEST_ALL_PREFIXES(ServiceWorkerFailToStartTest, Timeout);
@@ -325,7 +325,6 @@ class CONTENT_EXPORT ServiceWorkerVersion
TimeoutStartingWorker);
FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionBrowserTest,
TimeoutWorkerInEvent);
- friend class ServiceWorkerVersionBrowserTest;
typedef ServiceWorkerVersion self;
using ServiceWorkerClients = std::vector<ServiceWorkerClientInfo>;
@@ -492,9 +491,10 @@ class CONTENT_EXPORT ServiceWorkerVersion
ServiceWorkerStatusCode default_code);
const int64 version_id_;
- int64 registration_id_;
- GURL script_url_;
- GURL scope_;
+ const int64 registration_id_;
+ const GURL script_url_;
+ const GURL scope_;
+
Status status_;
scoped_ptr<EmbeddedWorkerInstance> embedded_worker_;
std::vector<StatusCallback> start_callbacks_;
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698