Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7350)

Unified Diff: chrome/common/form_field.h

Issue 11000016: Move forms/ out of webkit/. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Response to review Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/form_field.h
diff --git a/webkit/forms/form_field.h b/chrome/common/form_field.h
similarity index 81%
rename from webkit/forms/form_field.h
rename to chrome/common/form_field.h
index 0e92d9872d1a5609c39a1fa1f55a4b8710ecca93..06c9916e4d2aaa49a38cb431157342ff99ef9573 100644
--- a/webkit/forms/form_field.h
+++ b/chrome/common/form_field.h
@@ -2,19 +2,17 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef WEBKIT_FORMS_FORM_FIELD_H_
-#define WEBKIT_FORMS_FORM_FIELD_H_
+#ifndef CHROME_COMMON_FORM_FIELD_H_
+#define CHROME_COMMON_FORM_FIELD_H_
#include <vector>
#include "base/string16.h"
-#include "webkit/forms/webkit_forms_export.h"
-namespace webkit {
-namespace forms {
+namespace chrome {
// Stores information about a field in a form.
-struct WEBKIT_FORMS_EXPORT FormField {
+struct FormField {
FormField();
virtual ~FormField();
@@ -44,11 +42,9 @@ struct WEBKIT_FORMS_EXPORT FormField {
};
// So we can compare FormFields with EXPECT_EQ().
-WEBKIT_FORMS_EXPORT std::ostream& operator<<(std::ostream& os,
- const FormField& field);
+std::ostream& operator<<(std::ostream& os, const FormField& field);
-} // namespace forms
-} // namespace webkit
+} // namespace chrome
// Prefer to use this macro in place of |EXPECT_EQ()| for comparing |FormField|s
// in test code.
@@ -63,4 +59,4 @@ WEBKIT_FORMS_EXPORT std::ostream& operator<<(std::ostream& os,
EXPECT_EQ(expected.is_autofilled, actual.is_autofilled); \
} while (0)
-#endif // WEBKIT_FORMS_FORM_FIELD_H_
+#endif // CHROME_COMMON_FORM_FIELD_H_

Powered by Google App Engine
This is Rietveld 408576698