Move forms/ out of webkit/.

chrome/common/form_field_predictions.h

Index: chrome/common/form_field_predictions.h
diff --git a/webkit/forms/form_field_predictions.h b/chrome/common/form_field_predictions.h
similarity index 58%
rename from webkit/forms/form_field_predictions.h
rename to chrome/common/form_field_predictions.h
index 95f2d824db1d1d507d13fdba63606f74b3d57b5a..677116d831eb8e6777a86f4a76ce896814af2e2a 100644
--- a/webkit/forms/form_field_predictions.h
+++ b/chrome/common/form_field_predictions.h
@@ -2,20 +2,18 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef WEBKIT_FORMS_FORM_FIELD_PREDICTIONS_H_
-#define WEBKIT_FORMS_FORM_FIELD_PREDICTIONS_H_
+#ifndef CHROME_COMMON_FORM_FIELD_PREDICTIONS_H_
+#define CHROME_COMMON_FORM_FIELD_PREDICTIONS_H_
 
 #include <string>
 #include <vector>
 
-#include "webkit/forms/form_field.h"
-#include "webkit/forms/webkit_forms_export.h"
+#include "chrome/common/form_field.h"
 
-namespace webkit {
-namespace forms {
+namespace chrome {

[jam, 2012/10/04 06:18:12]

nit: no need for chrome namespace. code in src/chrome generally doesn't need to
be in a namespace; only code in modules which chrome depends on need to be in a
namespace (this was discussed on chromium-dev a while back)

[blundell, 2012/10/04 16:23:22]

Thanks. Done for all of the files that I brought into chrome/. I had to rename
form_field.*, as chrome/browser/autofill/form_field.* already exists. Chose
form_field_data to parallel form_data.

On 2012/10/04 06:18:12, John Abd-El-Malek wrote:

 
 // Stores information about a field in a form.
-struct WEBKIT_FORMS_EXPORT FormFieldPredictions {
+struct FormFieldPredictions {
   FormFieldPredictions();
   FormFieldPredictions(const FormFieldPredictions& other);
   ~FormFieldPredictions();
@@ -27,7 +25,6 @@ struct WEBKIT_FORMS_EXPORT FormFieldPredictions {
   std::string overall_type;
 };
 
-}  // namespace forms
-}  // namespace webkit
+}  // namespace chrome
 
-#endif  // WEBKIT_FORMS_FORM_FIELD_PREDICTIONS_H_
+#endif  // CHROME_COMMON_FORM_FIELD_PREDICTIONS_H_