Source/core/html/canvas/WebGLRenderingContextBase.h - Issue 1099853002: WebGL: add targets for WebGL 2 when check FBO targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLRenderingContextBase.h

Issue 1099853002: WebGL: add targets for WebGL 2 when check FBO targets (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed kbr@'s feedback: add a validation function to make it clear Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/html/canvas/WebGL2RenderingContextBase.cpp ('k') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('j') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLRenderingContextBase.h

diff --git a/Source/core/html/canvas/WebGLRenderingContextBase.h b/Source/core/html/canvas/WebGLRenderingContextBase.h

index 4611dc42c179fcf3d0d3cef4cc2019e7147d8911..f9c7feeb87479057e72b09d0e2619d097cd0d8a8 100644

--- a/Source/core/html/canvas/WebGLRenderingContextBase.h

+++ b/Source/core/html/canvas/WebGLRenderingContextBase.h

@@ -881,6 +881,9 @@ protected:

// used only to warn about use of obsolete functions.

void printWarningToConsole(const String&);

+ // Helper function to validate the target for checkFramebufferStatus and validateFramebufferFuncParameters.

+ virtual bool validateFramebufferTarget(GLenum target);

// Helper function to validate input parameters for framebuffer functions.

// Generate GL error if parameters are illegal.

bool validateFramebufferFuncParameters(const char* functionName, GLenum target, GLenum attachment);