Source/core/html/canvas/WebGL2RenderingContextBase.cpp - Issue 1099853002: WebGL: add targets for WebGL 2 when check FBO targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGL2RenderingContextBase.cpp

Issue 1099853002: WebGL: add targets for WebGL 2 when check FBO targets (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed kbr@'s feedback: add a validation function to make it clear Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/html/canvas/WebGL2RenderingContextBase.h ('k') | Source/core/html/canvas/WebGLRenderingContextBase.h » ('j') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGL2RenderingContextBase.cpp

diff --git a/Source/core/html/canvas/WebGL2RenderingContextBase.cpp b/Source/core/html/canvas/WebGL2RenderingContextBase.cpp

index 6c8c1a0e95a365cb61977b682b9f55015ac96cea..038523713cb6d4ed7abdea6d269e603078f4d33d 100644

--- a/Source/core/html/canvas/WebGL2RenderingContextBase.cpp

+++ b/Source/core/html/canvas/WebGL2RenderingContextBase.cpp

@@ -1461,6 +1461,18 @@ bool WebGL2RenderingContextBase::validateAndUpdateBufferBindTarget(const char* f

return true;

}

+bool WebGL2RenderingContextBase::validateFramebufferTarget(GLenum target)

+ switch (target) {

+ case GL_FRAMEBUFFER:

+ case GL_READ_FRAMEBUFFER:

+ case GL_DRAW_FRAMEBUFFER:

+ return true;

+ default:

+ return false;

+ }

DEFINE_TRACE(WebGL2RenderingContextBase)

{

visitor->trace(m_readFramebufferBinding);