Source/core/html/canvas/WebGL2RenderingContextBase.h - Issue 1099853002: WebGL: add targets for WebGL 2 when check FBO targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGL2RenderingContextBase.h

Issue 1099853002: WebGL: add targets for WebGL 2 when check FBO targets (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed kbr@'s feedback: add a validation function to make it clear Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/canvas/WebGL2RenderingContextBase.h

diff --git a/Source/core/html/canvas/WebGL2RenderingContextBase.h b/Source/core/html/canvas/WebGL2RenderingContextBase.h

index e7f0295bcf281d80e4728bf0ce99af8f9e985063..00ae82d336b0da399922a6198e9b2d3341bf5f03 100644

--- a/Source/core/html/canvas/WebGL2RenderingContextBase.h

+++ b/Source/core/html/canvas/WebGL2RenderingContextBase.h

@@ -177,6 +177,7 @@ protected:

bool validateCapability(const char* functionName, GLenum) override;

bool validateBufferTarget(const char* functionName, GLenum target) override;

bool validateAndUpdateBufferBindTarget(const char* functionName, GLenum, WebGLBuffer*) override;

+ bool validateFramebufferTarget(GLenum target) override;

RefPtrWillBeMember<WebGLFramebuffer> m_readFramebufferBinding;

};

« no previous file with comments | « no previous file | Source/core/html/canvas/WebGL2RenderingContextBase.cpp » ('j') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('J')