Source/core/html/canvas/WebGL2RenderingContextBase.h - Issue 1099853002: WebGL: add targets for WebGL 2 when check FBO targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGL2RenderingContextBase.h

Issue 1099853002: WebGL: add targets for WebGL 2 when check FBO targets (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed kbr@'s feedback: get the 'correct' framebuffer bound to give target Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/canvas/WebGL2RenderingContextBase.h

diff --git a/Source/core/html/canvas/WebGL2RenderingContextBase.h b/Source/core/html/canvas/WebGL2RenderingContextBase.h

index 3c7987bbc47def594e6a09bb56ac269734ef3a99..08aa6d762a9858533e691d32c5c33d0fa99ac4e0 100644

--- a/Source/core/html/canvas/WebGL2RenderingContextBase.h

+++ b/Source/core/html/canvas/WebGL2RenderingContextBase.h

@@ -179,6 +179,8 @@ protected:

bool validateBufferTarget(const char* functionName, GLenum target) override;

bool validateAndUpdateBufferBindTarget(const char* functionName, GLenum, WebGLBuffer*) override;

WebGLTexture* validateTextureBinding(const char* functionName, GLenum target, bool useSixEnumsForCubeMap) override;

+ bool validateFramebufferTarget(GLenum target) override;

+ RefPtrWillBeMember<WebGLFramebuffer> getFramebufferBinding(GLenum target) override;

RefPtrWillBeMember<WebGLFramebuffer> m_readFramebufferBinding;

};

« no previous file with comments | « no previous file | Source/core/html/canvas/WebGL2RenderingContextBase.cpp » ('j') | Source/core/html/canvas/WebGLRenderingContextBase.h » ('J')