Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1099803003: [chrome/browser/media] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 8 months ago
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/media BUG=466848 Committed: https://crrev.com/ab22734d8abd103a3b638839737989c193b91829 Cr-Commit-Position: refs/heads/master@{#326525}

Patch Set 1 #

Patch Set 2 : Fixed build issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -83 lines) Patch
M chrome/browser/media/desktop_media_list_ash.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/desktop_streams_registry.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 22 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/media/media_device_id_salt.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media/media_stream_device_permissions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/webrtc_log_util.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/webrtc_logging_handler_host.cc View 30 chunks +33 lines, -33 lines 0 comments Download
M chrome/browser/media/webrtc_rtp_dump_handler.cc View 11 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
anujsharma
PTAL
5 years, 8 months ago (2015-04-21 13:49:51 UTC) #2
xhwang
s/xhwang/tommi tommi: PTAL
5 years, 8 months ago (2015-04-21 15:39:39 UTC) #4
tommi (sloooow) - chröme
lgtm
5 years, 8 months ago (2015-04-23 14:39:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099803003/20001
5 years, 8 months ago (2015-04-23 14:39:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 15:43:15 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 15:44:16 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab22734d8abd103a3b638839737989c193b91829
Cr-Commit-Position: refs/heads/master@{#326525}

Powered by Google App Engine
This is Rietveld 408576698