chrome/browser/media/media_device_id_salt.cc - Issue 1099803003: [chrome/browser/media] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/media_device_id_salt.cc

Issue 1099803003: [chrome/browser/media] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed build issue Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/media_capture_devices_dispatcher.cc ('k') | chrome/browser/media/media_stream_device_permissions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/media_device_id_salt.cc

diff --git a/chrome/browser/media/media_device_id_salt.cc b/chrome/browser/media/media_device_id_salt.cc

index 27da539cd8aefd1ce2b72ed85fad9d37506b8707..3226c70f5da6bdfb7b3ac2686bde06fecc0e5c8f 100644

--- a/chrome/browser/media/media_device_id_salt.cc

+++ b/chrome/browser/media/media_device_id_salt.cc

@@ -25,7 +25,7 @@ std::string CreateSalt() {

MediaDeviceIDSalt::MediaDeviceIDSalt(PrefService* pref_service,

bool incognito) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

if (incognito) {

incognito_salt_ = CreateSalt();

@@ -44,13 +44,13 @@ MediaDeviceIDSalt::~MediaDeviceIDSalt() {

}

void MediaDeviceIDSalt::ShutdownOnUIThread() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

if (incognito_salt_.empty())

media_device_id_salt_.Destroy();

}

std::string MediaDeviceIDSalt::GetSalt() const {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

if (incognito_salt_.size())

return incognito_salt_;

return media_device_id_salt_.GetValue();