Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 1099633003: Bind BrowserCdmManager callbacks to UI thread before passing to CDM. (Closed)

Created:
5 years, 8 months ago by gunsch
Modified:
5 years, 8 months ago
Reviewers:
xhwang
CC:
chromium-reviews, eme-reviews_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bind BrowserCdmManager callbacks to UI thread before passing to CDM. R=xhwang@chromium.org BUG=478808 Committed: https://crrev.com/5ffcbfc45f3ffff328a85025f1e61a76655b7a76 Cr-Commit-Position: refs/heads/master@{#325898}

Patch Set 1 #

Total comments: 1

Patch Set 2 : moves BindToCurrentLoop to chromecast/ code #

Patch Set 3 : header for ~CdmKeyInformation (BindToCurrentLoop call required definition) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chromecast/browser/media/cast_browser_cdm_factory.cc View 1 2 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
5 years, 8 months ago (2015-04-20 17:51:21 UTC) #1
xhwang
Thanks! LGTM with nit. https://codereview.chromium.org/1099633003/diff/1/content/browser/media/cdm/browser_cdm_manager.cc File content/browser/media/cdm/browser_cdm_manager.cc (right): https://codereview.chromium.org/1099633003/diff/1/content/browser/media/cdm/browser_cdm_manager.cc#newcode446 content/browser/media/cdm/browser_cdm_manager.cc:446: render_frame_id, cdm_id)) This will cause ...
5 years, 8 months ago (2015-04-20 18:21:12 UTC) #2
gunsch
PTAL: moved to chromecast/
5 years, 8 months ago (2015-04-20 18:38:43 UTC) #3
xhwang
LGTM! Thanks!
5 years, 8 months ago (2015-04-20 18:41:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099633003/40001
5 years, 8 months ago (2015-04-20 18:57:16 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-20 20:25:54 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 20:26:40 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5ffcbfc45f3ffff328a85025f1e61a76655b7a76
Cr-Commit-Position: refs/heads/master@{#325898}

Powered by Google App Engine
This is Rietveld 408576698