Bind BrowserCdmManager callbacks to UI thread before passing to CDM.

content/browser/media/cdm/browser_cdm_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/cdm/browser_cdm_manager.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/task_runner.h"
 #include "content/common/media/cdm_messages.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/permission_manager.h"
 #include "content/public/browser/permission_type.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
+#include "media/base/bind_to_current_loop.h"
 #include "media/base/browser_cdm.h"
 #include "media/base/browser_cdm_factory.h"
 #include "media/base/cdm_promise.h"
 #include "media/base/limits.h"
 
 #if defined(OS_ANDROID)
 #include "content/public/common/renderer_preferences.h"
 #endif
 
 namespace content {
@@ skipping 399 matching lines @@
 
   cdm->CloseSession(session_id, promise.Pass());
 }
 
 void BrowserCdmManager::OnDestroyCdm(int render_frame_id, int cdm_id) {
   DCHECK(task_runner_->RunsTasksOnCurrentThread());
   RemoveCdm(GetId(render_frame_id, cdm_id));
 }
 
 // Use a weak pointer here instead of |this| to avoid circular references.
-#define BROWSER_CDM_MANAGER_CB(func)                                   \
-  base::Bind(&BrowserCdmManager::func, weak_ptr_factory_.GetWeakPtr(), \
-             render_frame_id, cdm_id)
+#define BROWSER_CDM_MANAGER_CB(func)                                       \
+  media::BindToCurrentLoop(                                                \
+      base::Bind(&BrowserCdmManager::func, weak_ptr_factory_.GetWeakPtr(), \
+                 render_frame_id, cdm_id))

[xhwang, 2015/04/20 18:21:12]

This will cause those callbacks to be posted always, even on Android where
everything lives on the UI thread. This is okay since the binded callbacks
aren't very frequent. Can you add a comment on why this is needed and note that
this will always cause a post?

 
 void BrowserCdmManager::AddCdm(int render_frame_id,
                                int cdm_id,
                                const std::string& key_system,
                                const GURL& security_origin) {
   DCHECK(task_runner_->RunsTasksOnCurrentThread());
   DCHECK(!GetCdm(render_frame_id, cdm_id));
 
   bool use_secure_surface = false;
 
@@ skipping 127 matching lines @@
   }
 
   // Only the temporary session type is supported in browser CDM path.
   // TODO(xhwang): Add SessionType support if needed.
   cdm->CreateSessionAndGenerateRequest(media::MediaKeys::TEMPORARY_SESSION,
                                        init_data_type, &init_data[0],
                                        init_data.size(), promise.Pass());
 }
 
 }  // namespace content