lib/compiler/implementation/ssa/optimize.dart - Issue 10996062: Use static final empty Modifier instead of null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/optimize.dart

Issue 10996062: Use static final empty Modifier instead of null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Missing uses fixed. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/ssa/optimize.dart

diff --git a/lib/compiler/implementation/ssa/optimize.dart b/lib/compiler/implementation/ssa/optimize.dart

index 9a3322d12bc68856232172492e3eb1fc5669d730..3bae34d7eef590950bdf7eceb3d81b061a00b920 100644

--- a/lib/compiler/implementation/ssa/optimize.dart

+++ b/lib/compiler/implementation/ssa/optimize.dart

@@ -579,10 +579,7 @@ class SsaConstantFolder extends HBaseVisitor implements OptimizationPhase {

if (field == null) return node;

Modifiers modifiers = field.modifiers;

- bool isFinalOrConst = false;

- if (modifiers != null) {

- isFinalOrConst = modifiers.isFinal() || modifiers.isConst();

- }

+ bool isFinalOrConst = modifiers.isFinal() || modifiers.isConst();

if (!compiler.resolverWorld.hasInvokedSetter(field, compiler)) {

// If no setter is ever used for this field it is only initialized in the

// initializer list.