Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1099573002: Migrate error messages, part 4 (v8natives.js). (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate error messages, part 4 (v8natives.js). Goal is to reduce native context size. R=mvstanton@chromium.org Committed: https://crrev.com/9b2fe70d93d5956c5731b6c84f65ad8bc0077a77 Cr-Commit-Position: refs/heads/master@{#27953}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix wrong assertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -124 lines) Patch
M src/harmony-spread.js View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.h View 1 chunk +60 lines, -28 lines 0 comments Download
M src/messages.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/messages.js View 5 chunks +1 line, -18 lines 0 comments Download
M src/object-observe.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.cc View 1 4 chunks +8 lines, -11 lines 0 comments Download
M src/proxy.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/string.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8natives.js View 42 chunks +51 lines, -55 lines 0 comments Download
M test/mjsunit/messages.js View 6 chunks +123 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Yang
5 years, 8 months ago (2015-04-20 12:04:20 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099573002/1
5 years, 8 months ago (2015-04-20 12:12:36 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/1945)
5 years, 8 months ago (2015-04-20 12:27:57 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099573002/20001
5 years, 8 months ago (2015-04-20 12:49:35 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/5033)
5 years, 8 months ago (2015-04-20 13:13:22 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099573002/40001
5 years, 8 months ago (2015-04-20 13:34:22 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-20 15:21:57 UTC) #13
Yang
On 2015/04/20 15:21:57, I haz the power (commit-bot) wrote: > Dry run: This issue passed ...
5 years, 8 months ago (2015-04-21 06:43:10 UTC) #14
mvstanton
LGTM. I like the new tests, +1!
5 years, 8 months ago (2015-04-21 08:19:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099573002/40001
5 years, 8 months ago (2015-04-21 09:03:08 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-21 09:03:29 UTC) #18
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 09:03:40 UTC) #19
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9b2fe70d93d5956c5731b6c84f65ad8bc0077a77
Cr-Commit-Position: refs/heads/master@{#27953}

Powered by Google App Engine
This is Rietveld 408576698