src/messages.cc - Issue 1099573002: Migrate error messages, part 4 (v8natives.js).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.cc

Issue 1099573002: Migrate error messages, part 4 (v8natives.js). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix wrong assertion Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/messages.cc

diff --git a/src/messages.cc b/src/messages.cc

index c39f4e684800b7f3266d3202dd89c95f93d888c4..bdfc5180b408804e907528c5e724ec96418d9430 100644

--- a/src/messages.cc

+++ b/src/messages.cc

@@ -189,8 +189,8 @@ MaybeHandle<String> MessageTemplate::FormatMessage(int template_index,

Handle<String> args[] = {arg0, arg1, arg2};

for (const char* c = template_string; *c != '\0'; c++) {

if (*c == '%') {

- builder.AppendString(args[i++]);

DCHECK(i < arraysize(args));

+ builder.AppendString(args[i++]);

} else {

builder.AppendCharacter(*c);

}

« no previous file with comments | « src/messages.h ('k') | src/messages.js » ('j') | no next file with comments »