Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5224)

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 1099553002: extensions: windows: list all windows from the current profile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bitmask issue Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tab_util.cc
diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc
index 6ac0c78efe3740fb9ac52a4f370b64044abaaadd..384c94d02d22ec80fbcbd8b740115e7a2e445dc8 100644
--- a/chrome/browser/extensions/extension_tab_util.cc
+++ b/chrome/browser/extensions/extension_tab_util.cc
@@ -432,9 +432,10 @@ void ExtensionTabUtil::ScrubTabValueForExtension(
WebContents* contents,
const Extension* extension,
base::DictionaryValue* tab_info) {
- bool has_permission = extension &&
+ int tab_id = GetTabId(contents);
+ bool has_permission = tab_id >= 0 && extension &&
extension->permissions_data()->HasAPIPermissionForTab(
- GetTabId(contents), APIPermission::kTab);
+ tab_id, APIPermission::kTab);
if (!has_permission) {
tab_info->Remove(keys::kUrlKey, NULL);

Powered by Google App Engine
This is Rietveld 408576698