extensions: windows: list all windows from the current profile

chrome/browser/extensions/api/tabs/windows_util.cc

Index: chrome/browser/extensions/api/tabs/windows_util.cc
diff --git a/chrome/browser/extensions/api/tabs/windows_util.cc b/chrome/browser/extensions/api/tabs/windows_util.cc
index 0e2ead5b3e8b9c70018413ae476d90e05c3c2f49..4c9b0747842c881c1997088da2d7029284f5e60e 100644
--- a/chrome/browser/extensions/api/tabs/windows_util.cc
+++ b/chrome/browser/extensions/api/tabs/windows_util.cc
@@ -2,12 +2,16 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <string>
+#include <vector>
+
 #include "chrome/browser/extensions/api/tabs/windows_util.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
 #include "chrome/browser/extensions/chrome_extension_function.h"
 #include "chrome/browser/extensions/chrome_extension_function_details.h"
+#include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/window_controller.h"
 #include "chrome/browser/extensions/window_controller_list.h"
 #include "chrome/browser/profiles/profile.h"
@@ -15,11 +19,54 @@
 #include "extensions/browser/extension_function_dispatcher.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/error_utils.h"
+#include "extensions/common/extension.h"
+
+namespace keys = extensions::tabs_constants;
+namespace windows = extensions::api::windows;
 
 namespace windows_util {
 
+extensions::WindowTypeFilter GetDefaultWindowTypeFilter() {
+  return (extensions::WINDOW_TYPE_FILTER_NORMAL |
+          extensions::WINDOW_TYPE_FILTER_PANEL |
+          extensions::WINDOW_TYPE_FILTER_POPUP);
+}
+
+extensions::WindowTypeFilter GetAllWindowTypeFilter() {
+  // extensions::WindowTypeFilterValues needs to be updated if there
+  // is a change to extensions::api::windows:WindowType.
+  COMPILE_ASSERT(extensions::api::windows::WINDOW_TYPE_LAST ==
+                     extensions::api::windows::WINDOW_TYPE_DEVTOOLS,
+                 Update_WindowControllerList_to_match_WindowType);
+  COMPILE_ASSERT((1 << extensions::api::windows::WINDOW_TYPE_DEVTOOLS) ==
+                     extensions::WINDOW_TYPE_FILTER_DEVTOOLS,
+                 Update_WindowControllerList_to_match_WindowType);
+  return (extensions::WINDOW_TYPE_FILTER_NORMAL |
+          extensions::WINDOW_TYPE_FILTER_PANEL |
+          extensions::WINDOW_TYPE_FILTER_POPUP |
+          extensions::WINDOW_TYPE_FILTER_APP |
+          extensions::WINDOW_TYPE_FILTER_DEVTOOLS);
+}
+
+bool WindowMatchesTypeFilter(const extensions::WindowController* controller,
+                             extensions::WindowTypeFilter filter) {
+  extensions::WindowTypeFilter type =
+      1 << extensions::api::windows::ParseWindowType(
+          controller->GetWindowTypeText());
+  return (type & filter) != 0;
+}
+
+extensions::WindowTypeFilter WindowTypeFilterFromWindowTypes(
+    const std::vector<extensions::api::windows::WindowType>& types) {
+  extensions::WindowTypeFilter filter = 0;
+  for (unsigned int i = 0; i < types.size(); i++)
+    filter |= 1 << types[i];
+  return filter;
+}
+
 bool GetWindowFromWindowID(UIThreadExtensionFunction* function,
                            int window_id,
+                           extensions::WindowTypeFilter filter,
                            extensions::WindowController** controller) {
   if (window_id == extension_misc::kCurrentWindowId) {
     extensions::WindowController* extension_window_controller =
@@ -37,8 +84,9 @@ bool GetWindowFromWindowID(UIThreadExtensionFunction* function,
       return false;
     }
   } else {
-    *controller = extensions::WindowControllerList::GetInstance()
-                      ->FindWindowForFunctionById(function, window_id);
+    *controller =
+        extensions::WindowControllerList::GetInstance()
+            ->FindWindowForFunctionByIdWithFilter(function, window_id, filter);
     if (!(*controller)) {
       function->SetError(extensions::ErrorUtils::FormatErrorMessage(
           extensions::tabs_constants::kWindowNotFoundError,
@@ -50,11 +98,10 @@ bool GetWindowFromWindowID(UIThreadExtensionFunction* function,
 }
 
 bool CanOperateOnWindow(const UIThreadExtensionFunction* function,
-                        const extensions::WindowController* controller) {
-  if (function->extension() != NULL &&
-      !controller->IsVisibleToExtension(function->extension())) {
+                        const extensions::WindowController* controller,
+                        extensions::WindowTypeFilter filter) {
+  if (!WindowMatchesTypeFilter(controller, filter))
     return false;
-  }
 
   if (function->browser_context() == controller->profile())
     return true;