Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1099473003: gfx::Image: AddRepresentation takes a scoped_ptr, not a raw ptr. (Closed)

Created:
5 years, 8 months ago by Matt Giuca
Modified:
5 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, rsesek+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@base-scopedmap
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gfx::Image: AddRepresentation takes a scoped_ptr, not a raw ptr. This is just a small cleanup which makes ownership clearer. Because AddRepresentation is going to retain ownership of the ImageRep argument, it should accept it as a scoped_ptr. Updated callers. Committed: https://crrev.com/a98a4db15b9affbd2d03cd8a2809ca2f0c1fdbac Cr-Commit-Position: refs/heads/master@{#326005}

Patch Set 1 #

Patch Set 2 : Fix potential null dereference (use after release). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -36 lines) Patch
M ui/gfx/image/image.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gfx/image/image.cc View 1 12 chunks +35 lines, -35 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Matt Giuca
5 years, 8 months ago (2015-04-20 05:41:10 UTC) #2
Robert Sesek
LGTM
5 years, 8 months ago (2015-04-20 18:59:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099473003/1
5 years, 8 months ago (2015-04-21 01:47:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/75479)
5 years, 8 months ago (2015-04-21 05:25:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099473003/20001
5 years, 8 months ago (2015-04-21 07:39:50 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-21 10:25:53 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 10:26:40 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a98a4db15b9affbd2d03cd8a2809ca2f0c1fdbac
Cr-Commit-Position: refs/heads/master@{#326005}

Powered by Google App Engine
This is Rietveld 408576698