gfx::Image: AddRepresentation takes a scoped_ptr, not a raw ptr.

ui/gfx/image/image.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/image/image.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/logging.h"
-#include "base/memory/scoped_ptr.h"
 #include "base/stl_util.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gfx/image/image_png_rep.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/image/image_skia_source.h"
 
 #if !defined(OS_IOS)
 #include "ui/gfx/codec/png_codec.h"
 #endif
@@ skipping 378 matching lines @@
   std::vector<ImagePNGRep> filtered;
   for (size_t i = 0; i < image_reps.size(); ++i) {
     if (image_reps[i].raw_data.get() && image_reps[i].raw_data->size())
       filtered.push_back(image_reps[i]);
   }
 
   if (filtered.empty())
     return;
 
   storage_ = new internal::ImageStorage(Image::kImageRepPNG);
-  internal::ImageRepPNG* rep = new internal::ImageRepPNG(filtered);
-  AddRepresentation(rep);
+  AddRepresentation(make_scoped_ptr(new internal::ImageRepPNG(filtered)));
 }
 
 Image::Image(const ImageSkia& image) {
   if (!image.isNull()) {
     storage_ = new internal::ImageStorage(Image::kImageRepSkia);
-    internal::ImageRepSkia* rep = new internal::ImageRepSkia(
-        new ImageSkia(image));
-    AddRepresentation(rep);
+    AddRepresentation(
+        make_scoped_ptr(new internal::ImageRepSkia(new ImageSkia(image))));
   }
 }
 
 #if defined(OS_IOS)
 Image::Image(UIImage* image)
     : storage_(new internal::ImageStorage(Image::kImageRepCocoaTouch)) {
-  if (image) {
-    internal::ImageRepCocoaTouch* rep = new internal::ImageRepCocoaTouch(image);
-    AddRepresentation(rep);
-  }
+  if (image)
+    AddRepresentation(make_scoped_ptr(new internal::ImageRepCocoaTouch(image)));
 }
 #elif defined(OS_MACOSX)
 Image::Image(NSImage* image) {
   if (image) {
     storage_ = new internal::ImageStorage(Image::kImageRepCocoa);
-    internal::ImageRepCocoa* rep = new internal::ImageRepCocoa(image);
-    AddRepresentation(rep);
+    AddRepresentation(make_scoped_ptr(new internal::ImageRepCocoa(image)));
   }
 }
 #endif
 
 Image::Image(const Image& other) : storage_(other.storage_) {
 }
 
 Image& Image::operator=(const Image& other) {
   storage_ = other.storage_;
   return *this;
@@ skipping 30 matching lines @@
 }
 
 const SkBitmap* Image::ToSkBitmap() const {
   // Possibly create and cache an intermediate ImageRepSkia.
   return ToImageSkia()->bitmap();
 }
 
 const ImageSkia* Image::ToImageSkia() const {
   internal::ImageRep* rep = GetRepresentation(kImageRepSkia, false);
   if (!rep) {
+    scoped_ptr<internal::ImageRep> scoped_rep;
     switch (DefaultRepresentationType()) {
       case kImageRepPNG: {
         internal::ImageRepPNG* png_rep =
             GetRepresentation(kImageRepPNG, true)->AsImageRepPNG();
-        rep = new internal::ImageRepSkia(
-            internal::ImageSkiaFromPNG(png_rep->image_reps()));
+        scoped_rep.reset(new internal::ImageRepSkia(
+            internal::ImageSkiaFromPNG(png_rep->image_reps())));
         break;
       }
 #if defined(OS_IOS)
       case kImageRepCocoaTouch: {
         internal::ImageRepCocoaTouch* native_rep =
             GetRepresentation(kImageRepCocoaTouch, true)
                 ->AsImageRepCocoaTouch();
-        rep = new internal::ImageRepSkia(new ImageSkia(
-            ImageSkiaFromUIImage(native_rep->image())));
+        scoped_rep.reset(new internal::ImageRepSkia(
+            new ImageSkia(ImageSkiaFromUIImage(native_rep->image()))));
         break;
       }
 #elif defined(OS_MACOSX)
       case kImageRepCocoa: {
         internal::ImageRepCocoa* native_rep =
             GetRepresentation(kImageRepCocoa, true)->AsImageRepCocoa();
-        rep = new internal::ImageRepSkia(new ImageSkia(
-            ImageSkiaFromNSImage(native_rep->image())));
+        scoped_rep.reset(new internal::ImageRepSkia(
+            new ImageSkia(ImageSkiaFromNSImage(native_rep->image()))));
         break;
       }
 #endif
       default:
         NOTREACHED();
     }
-    CHECK(rep);
-    AddRepresentation(rep);
+    CHECK(scoped_rep);
+    rep = scoped_rep.get();
+    AddRepresentation(scoped_rep.Pass());
   }
   return rep->AsImageRepSkia()->image();
 }
 
 #if defined(OS_IOS)
 UIImage* Image::ToUIImage() const {
   internal::ImageRep* rep = GetRepresentation(kImageRepCocoaTouch, false);
   if (!rep) {
+    scoped_ptr<internal::ImageRep> scoped_rep;
     switch (DefaultRepresentationType()) {
       case kImageRepPNG: {
         internal::ImageRepPNG* png_rep =
             GetRepresentation(kImageRepPNG, true)->AsImageRepPNG();
-        rep = new internal::ImageRepCocoaTouch(internal::CreateUIImageFromPNG(
-            png_rep->image_reps()));
+        scoped_rep.reset(new internal::ImageRepCocoaTouch(
+            internal::CreateUIImageFromPNG(png_rep->image_reps())));
         break;
       }
       case kImageRepSkia: {
         internal::ImageRepSkia* skia_rep =
             GetRepresentation(kImageRepSkia, true)->AsImageRepSkia();
         UIImage* image = UIImageFromImageSkia(*skia_rep->image());
         base::mac::NSObjectRetain(image);
-        rep = new internal::ImageRepCocoaTouch(image);
+        scoped_rep.reset(new internal::ImageRepCocoaTouch(image));
         break;
       }
       default:
         NOTREACHED();
     }
-    CHECK(rep);
-    AddRepresentation(rep);
+    CHECK(scoped_rep);
+    rep = scoped_rep.get();
+    AddRepresentation(scoped_rep.Pass());
   }
   return rep->AsImageRepCocoaTouch()->image();
 }
 #elif defined(OS_MACOSX)
 NSImage* Image::ToNSImage() const {
   internal::ImageRep* rep = GetRepresentation(kImageRepCocoa, false);
   if (!rep) {
+    scoped_ptr<internal::ImageRep> scoped_rep;
     CGColorSpaceRef default_representation_color_space =
         storage_->default_representation_color_space();
 
     switch (DefaultRepresentationType()) {
       case kImageRepPNG: {
         internal::ImageRepPNG* png_rep =
             GetRepresentation(kImageRepPNG, true)->AsImageRepPNG();
-        rep = new internal::ImageRepCocoa(internal::NSImageFromPNG(
-            png_rep->image_reps(), default_representation_color_space));
+        scoped_rep.reset(new internal::ImageRepCocoa(internal::NSImageFromPNG(
+            png_rep->image_reps(), default_representation_color_space)));
         break;
       }
       case kImageRepSkia: {
         internal::ImageRepSkia* skia_rep =
             GetRepresentation(kImageRepSkia, true)->AsImageRepSkia();
         NSImage* image = NSImageFromImageSkiaWithColorSpace(*skia_rep->image(),
             default_representation_color_space);
         base::mac::NSObjectRetain(image);
-        rep = new internal::ImageRepCocoa(image);
+        scoped_rep.reset(new internal::ImageRepCocoa(image));
         break;
       }
       default:
         NOTREACHED();
     }
-    CHECK(rep);
-    AddRepresentation(rep);
+    CHECK(scoped_rep);
+    rep = scoped_rep.get();
+    AddRepresentation(scoped_rep.Pass());
   }
   return rep->AsImageRepCocoa()->image();
 }
 #endif
 
 scoped_refptr<base::RefCountedMemory> Image::As1xPNGBytes() const {
   if (IsEmpty())
     return new base::RefCountedBytes();
 
   internal::ImageRep* rep = GetRepresentation(kImageRepPNG, false);
@@ skipping 32 matching lines @@
           GetRepresentation(kImageRepSkia, true)->AsImageRepSkia();
       png_bytes = internal::Get1xPNGBytesFromImageSkia(skia_rep->image());
       break;
     }
     default:
       NOTREACHED();
   }
   if (!png_bytes.get() || !png_bytes->size()) {
     // Add an ImageRepPNG with no data such that the conversion is not
     // attempted each time we want the PNG bytes.
-    AddRepresentation(new internal::ImageRepPNG());
+    AddRepresentation(make_scoped_ptr(new internal::ImageRepPNG()));
     return new base::RefCountedBytes();
   }
 
   // Do not insert representations for scale factors other than 1x even if
   // they are available because:
   // - Only the 1x PNG bytes can be accessed.
   // - ImageRepPNG is not used as an intermediate type in converting to a
   //   final type eg (converting from ImageRepSkia to ImageRepPNG to get an
   //   ImageRepCocoa).
   std::vector<ImagePNGRep> image_png_reps;
   image_png_reps.push_back(ImagePNGRep(png_bytes, 1.0f));
-  rep = new internal::ImageRepPNG(image_png_reps);
-  AddRepresentation(rep);
+  AddRepresentation(make_scoped_ptr(new internal::ImageRepPNG(image_png_reps)));
   return png_bytes;
 }
 
 SkBitmap Image::AsBitmap() const {
   return IsEmpty() ? SkBitmap() : *ToSkBitmap();
 }
 
 ImageSkia Image::AsImageSkia() const {
   return IsEmpty() ? ImageSkia() : *ToImageSkia();
 }
@@ skipping 86 matching lines @@
     RepresentationType rep_type, bool must_exist) const {
   CHECK(storage_.get());
   RepresentationMap::iterator it = storage_->representations().find(rep_type);
   if (it == storage_->representations().end()) {
     CHECK(!must_exist);
     return NULL;
   }
   return it->second;
 }
 
-void Image::AddRepresentation(internal::ImageRep* rep) const {
+void Image::AddRepresentation(scoped_ptr<internal::ImageRep> rep) const {
   CHECK(storage_.get());
-  storage_->representations().insert(std::make_pair(rep->type(), rep));
+  RepresentationType type = rep->type();
+  storage_->representations().insert(std::make_pair(type, rep.release()));
 }
 
 }  // namespace gfx