components/autofill/content/browser/DEPS - Issue 1099453005: Switch web API/permission code to use IsOriginSecure() instead of SchemeIsSecure().

Side by Side Diff: components/autofill/content/browser/DEPS

Issue 1099453005: Switch web API/permission code to use IsOriginSecure() instead of SchemeIsSecure(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nhiroki's comment. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/banners/app_banner_manager.cc ('K') | « chrome/browser/ui/website_settings/permission_menu_model.cc ('k') | components/autofill/content/browser/wallet/wallet_service_url_unittest.cc » ('j') | components/content_settings/core/browser/DEPS » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+chrome/common/origin_util.h",
	jww 2015/04/23 18:24:02 I'm pretty sure this is an invalid include and a l I'm pretty sure this is an invalid include and a layering violation. You'll want to check with a wiser person than me, but I think you're going to need to move origin_util.h into components or content if you want to include it in components. lgarron 2015/04/23 23:05:51 This felt wrong, but I just wanted it to compile f Show quoted text On 2015/04/23 at 18:24:02, jww wrote: > I'm pretty sure this is an invalid include and a layering violation. You'll want to check with a wiser person than me, but I think you're going to need to move origin_util.h into components or content if you want to include it in components. This felt wrong, but I just wanted it to compile first and ask later. :-P In this case, the solution appears to be just to move the function: https://codereview.chromium.org/1101033003/ In the future, is there a document that can help me understand what when something is a layering violation? Evan Stade 2015/04/24 02:26:02 Some of the DEPS files have some comments. From sr Show quoted text On 2015/04/23 23:05:51, lgarron wrote: > On 2015/04/23 at 18:24:02, jww wrote: > > I'm pretty sure this is an invalid include and a layering violation. You'll > want to check with a wiser person than me, but I think you're going to need to > move origin_util.h into components or content if you want to include it in > components. > > This felt wrong, but I just wanted it to compile first and ask later. :-P > > In this case, the solution appears to be just to move the function: > https://codereview.chromium.org/1101033003/ > In the future, is there a document that can help me understand what when > something is a layering violation? Some of the DEPS files have some comments. From src/content/DEPS: # Do NOT add chrome or components to the list below. We shouldn't be # including files from src/chrome or src/components in src/content. From src/components/DEPS: # Do not add chrome/ as an allowed include. # Individual components must explicitly declare their dependencies # on other components. Cycles in the dependency graph within # components/ are not allowed.
2 "+components/webdata/common",	3 "+components/webdata/common",

3 "+content/public/browser",	4 "+content/public/browser",

4 "+crypto/random.h",	5 "+crypto/random.h",

5 "+google_apis/gaia",	6 "+google_apis/gaia",

6 "+google_apis/google_api_keys.h",	7 "+google_apis/google_api_keys.h",

7 "+gpu/config/gpu_info.h",	8 "+gpu/config/gpu_info.h",

8 "+sql",	9 "+sql",

9 "+third_party/libjingle",	10 "+third_party/libjingle",

10 "+third_party/libphonenumber", # For phone number i18n.	11 "+third_party/libphonenumber", # For phone number i18n.

11 ]	12 ]

12	13

13 specific_include_rules = {	14 specific_include_rules = {

14 '._[a-z]test\.cc': [	15 '._[a-z]test\.cc': [

15 "+content/public/test",	16 "+content/public/test",

16 ],	17 ],

17 }	18 }

OLD	NEW