[AiS] changing mac omnibox suggestions form NSMatrix to NSTableView

chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
index c1de5a5cef41bb0d958da13bbfdc53004ceaaf2e..d7266a7fb98086d11063319ec610f333ee02cddb 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
@@ -12,10 +12,16 @@
 
 class OmniboxPopupViewMac;
 
+@interface AutocompleteMatchWrapper : NSObject {
+ @public
+  AutocompleteMatch match_;
+}
+@end
+
 // OmniboxPopupCell overrides how backgrounds are displayed to
 // handle hover versus selected.  So long as we're in there, it also
 // provides some default initialization.
-@interface OmniboxPopupCell : NSButtonCell {
+@interface OmniboxPopupCell : NSCell {

[groby-ooo-7-16, 2015/05/07 02:39:58]

We don't need any of NSButtonCell's behavior any more?

[dschuyler, 2015/05/07 20:53:09]

It doesn't seem so.  I'm going by Jayson's advice and my local testing.  The
button cell had some handy features if we're only doing a simple image/text
line.  With the coming AiS changes much more of it will need to be done by us to
get the layout we're doing.

  @private
   // The popup view parent of this cell.
   OmniboxPopupViewMac* parent_;
@@ -40,6 +46,8 @@ class OmniboxPopupViewMac;
   CGFloat contentsOffset_;
 }
 
+@property(nonatomic, readwrite, retain) NSAttributedString* attributedTitle;

[groby-ooo-7-16, 2015/05/07 02:39:58]

No need to specify readwrite - it's default. 

[dschuyler, 2015/05/07 20:53:09]

Done.

+
 - (void)setMatch:(const AutocompleteMatch&)match;
 
 - (void)setMaxMatchContentsWidth:(CGFloat)maxMatchContentsWidth;