[AiS] changing mac omnibox suggestions form NSMatrix to NSTableView

chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_CELL_H_
 #define CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_CELL_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/mac/scoped_nsobject.h"
 #include "components/omnibox/autocomplete_match.h"
 
 class OmniboxPopupViewMac;
 
+@interface AutocompleteMatchWrapper : NSObject {
+ @public
+  AutocompleteMatch match_;
+}
+@end
+
 // OmniboxPopupCell overrides how backgrounds are displayed to
 // handle hover versus selected.  So long as we're in there, it also
 // provides some default initialization.
-@interface OmniboxPopupCell : NSButtonCell {
+@interface OmniboxPopupCell : NSCell {

[groby-ooo-7-16, 2015/05/07 02:39:58]

We don't need any of NSButtonCell's behavior any more?

[dschuyler, 2015/05/07 20:53:09]

It doesn't seem so.  I'm going by Jayson's advice and my local testing.  The
button cell had some handy features if we're only doing a simple image/text
line.  With the coming AiS changes much more of it will need to be done by us to
get the layout we're doing.

  @private
   // The popup view parent of this cell.
   OmniboxPopupViewMac* parent_;
 
   // The match which will be rendered for this row in omnibox dropdown.
   AutocompleteMatch match_;
 
   // NSAttributedString instances for various match components.
   base::scoped_nsobject<NSAttributedString> separator_;
   base::scoped_nsobject<NSAttributedString> description_;
 
   // NOTE: While |prefix_| is used only for postfix suggestions, it still needs
   // to be a member of the class. This allows the |NSAttributedString| instance
   // to stay alive between the call to |drawTitle| and the actual paint event
   // which accesses the |NSAttributedString| instance.
   base::scoped_nsobject<NSAttributedString> prefix_;
 
   // The width of widest match contents in a set of infinite suggestions.
   CGFloat maxMatchContentsWidth_;
 
   // The offset at which the infinite suggesiton contents should be displayed.
   CGFloat contentsOffset_;
 }
 
+@property(nonatomic, readwrite, retain) NSAttributedString* attributedTitle;

[groby-ooo-7-16, 2015/05/07 02:39:58]

No need to specify readwrite - it's default. 

[dschuyler, 2015/05/07 20:53:09]

Done.

+
 - (void)setMatch:(const AutocompleteMatch&)match;
 
 - (void)setMaxMatchContentsWidth:(CGFloat)maxMatchContentsWidth;
 
 - (void)setContentsOffset:(CGFloat)contentsOffset;
 
 // Returns the width of the match contents.
 - (CGFloat)getMatchContentsWidth;
 
 // Returns the offset of the start of the contents in the input text for the
 // given match. It is costly to compute this offset, so it is computed once and
 // shared by all OmniboxPopupCell instances through OmniboxPopupViewMac parent.
 + (CGFloat)computeContentsOffset:(const AutocompleteMatch&)match;
 
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_CELL_H_