[AiS] changing mac omnibox suggestions form NSMatrix to NSTableView

chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
index c1de5a5cef41bb0d958da13bbfdc53004ceaaf2e..d0177cd4864302b11e3770fdba063d61b464d71f 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
@@ -15,11 +15,8 @@ class OmniboxPopupViewMac;
 // OmniboxPopupCell overrides how backgrounds are displayed to
 // handle hover versus selected.  So long as we're in there, it also
 // provides some default initialization.
-@interface OmniboxPopupCell : NSButtonCell {
+@interface OmniboxPopupCell : NSButtonCell<NSCopying> {
  @private
-  // The popup view parent of this cell.
-  OmniboxPopupViewMac* parent_;

[dschuyler, 2015/04/24 18:43:08]

This wasn't being used.

[groby-ooo-7-16, 2015/04/24 20:11:16]

If it's not used in existing code, might as well submit a separate cleanup CL.
It's useful independent of where this goes.

[Scott Hess - ex-Googler, 2015/04/25 06:04:27]

I support this message.  Also, I notice that a lot of the overall CL are
s/matrix/table/ type changes.  I wonder if it would make sense to instead just
have this own the abstraction and not export the implementation details.  Like
it could be OmniboxPopupControl or something (even if it later becomes a full-on
custom implementation, it seems likely to still be an NSControl subclass).

-
   // The match which will be rendered for this row in omnibox dropdown.
   AutocompleteMatch match_;