[AiS] changing mac omnibox suggestions form NSMatrix to NSTableView

chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_CELL_H_
 #define CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_CELL_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/mac/scoped_nsobject.h"
 #include "components/omnibox/autocomplete_match.h"
 
 class OmniboxPopupViewMac;
 
 // OmniboxPopupCell overrides how backgrounds are displayed to
 // handle hover versus selected.  So long as we're in there, it also
 // provides some default initialization.
-@interface OmniboxPopupCell : NSButtonCell {
+@interface OmniboxPopupCell : NSButtonCell<NSCopying> {
  @private
-  // The popup view parent of this cell.
-  OmniboxPopupViewMac* parent_;

[dschuyler, 2015/04/24 18:43:08]

This wasn't being used.

[groby-ooo-7-16, 2015/04/24 20:11:16]

If it's not used in existing code, might as well submit a separate cleanup CL.
It's useful independent of where this goes.

[Scott Hess - ex-Googler, 2015/04/25 06:04:27]

I support this message.  Also, I notice that a lot of the overall CL are
s/matrix/table/ type changes.  I wonder if it would make sense to instead just
have this own the abstraction and not export the implementation details.  Like
it could be OmniboxPopupControl or something (even if it later becomes a full-on
custom implementation, it seems likely to still be an NSControl subclass).

-
   // The match which will be rendered for this row in omnibox dropdown.
   AutocompleteMatch match_;
 
   // NSAttributedString instances for various match components.
   base::scoped_nsobject<NSAttributedString> separator_;
   base::scoped_nsobject<NSAttributedString> description_;
 
   // NOTE: While |prefix_| is used only for postfix suggestions, it still needs
   // to be a member of the class. This allows the |NSAttributedString| instance
   // to stay alive between the call to |drawTitle| and the actual paint event
@@ skipping 17 matching lines @@
 - (CGFloat)getMatchContentsWidth;
 
 // Returns the offset of the start of the contents in the input text for the
 // given match. It is costly to compute this offset, so it is computed once and
 // shared by all OmniboxPopupCell instances through OmniboxPopupViewMac parent.
 + (CGFloat)computeContentsOffset:(const AutocompleteMatch&)match;
 
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_CELL_H_