Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1099343004: Synchronize Android relocation packer source with AOSP. (Closed)

Created:
5 years, 8 months ago by simonb1
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Synchronize Android relocation packer source with AOSP. Imports: - https://android-review.googlesource.com/#/c/147620/ Exit normally when packing relocs saves no space - https://android-review.googlesource.com/#/c/147745/ Always use signed leb128 encoding - https://android-review.googlesource.com/#/c/148073/ Adjust DT_VERSYM/VERNEED/VERDEF dynamic sections BUG=385553 Committed: https://crrev.com/0be8ee5f43abf673de164bec5b52fecbdcee00bf Cr-Commit-Position: refs/heads/master@{#326836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -324 lines) Patch
M third_party/android_platform/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/android_platform/bionic/tools/relocation_packer/src/elf_file.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/android_platform/bionic/tools/relocation_packer/src/elf_file.cc View 10 chunks +24 lines, -9 lines 0 comments Download
M third_party/android_platform/bionic/tools/relocation_packer/src/elf_file_unittest.cc View 1 chunk +8 lines, -2 lines 0 comments Download
D third_party/android_platform/bionic/tools/relocation_packer/src/leb128.h View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/android_platform/bionic/tools/relocation_packer/src/leb128.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/android_platform/bionic/tools/relocation_packer/src/leb128_unittest.cc View 1 chunk +0 lines, -111 lines 0 comments Download
M third_party/android_platform/bionic/tools/relocation_packer/src/packer.cc View 3 chunks +8 lines, -29 lines 0 comments Download
M third_party/android_platform/bionic/tools/relocation_packer/src/packer_unittest.cc View 5 chunks +16 lines, -8 lines 0 comments Download
M third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm32_packed.so View Binary file 0 comments Download
M third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_arm64_packed.so View Binary file 0 comments Download
M third_party/android_platform/relocation_packer.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
simonb (inactive)
5 years, 8 months ago (2015-04-24 16:34:58 UTC) #2
rmcilroy
On 2015/04/24 16:34:58, simonb wrote: RSLGTM
5 years, 8 months ago (2015-04-24 17:11:27 UTC) #3
rmcilroy
On 2015/04/24 17:11:27, rmcilroy wrote: > On 2015/04/24 16:34:58, simonb wrote: > > RSLGTM let's ...
5 years, 8 months ago (2015-04-24 17:11:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099343004/1
5 years, 8 months ago (2015-04-24 17:42:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 18:06:58 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 18:07:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0be8ee5f43abf673de164bec5b52fecbdcee00bf
Cr-Commit-Position: refs/heads/master@{#326836}

Powered by Google App Engine
This is Rietveld 408576698