Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10993029: Extensions Docs Server: Fix headings with no IDs (Closed)

Created:
8 years, 2 months ago by cduvall
Modified:
8 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Extensions Docs Server: Fix headings with no IDs PRESUBMIT.py will check for headings with no IDs, and all headings that didn't have IDs now have IDs. BUG=149146 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159156

Patch Set 1 : #

Total comments: 10

Patch Set 2 : more descriptive ids #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -154 lines) Patch
M chrome/common/extensions/PRESUBMIT.py View 1 1 chunk +16 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_architecture.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_csp.html View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_external.html View 1 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_frameworks.html View 1 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_hardware.html View 1 17 chunks +21 lines, -21 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_identity.html View 1 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_intents.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_known_issues.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_lifecycle.html View 1 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_network.html View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/autoupdate.html View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/background_pages.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/crx.html View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/faq.html View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/first_app.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/i18n-messages.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/manifest.html View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/notifications.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/npapi.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/options.html View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/overview.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/packaging.html View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/sandboxingEval.html View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/tut_migration_to_manifest_v2.html View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/browserAction.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/devtools_inspectedWindow.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/devtools_network.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/devtools_panels.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/experimental_devtools_audits.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/webNavigation.html View 1 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/webRequest.html View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
cduvall
8 years, 2 months ago (2012-09-26 01:46:22 UTC) #1
not at google - send to devlin
lgtm I got fatigued thinking of anchor names for everything, so only commented on the ...
8 years, 2 months ago (2012-09-26 01:57:17 UTC) #2
cduvall
8 years, 2 months ago (2012-09-27 23:39:39 UTC) #3 
https://codereview.chromium.org/10993029/diff/2001/chrome/common/extensions/P...
File chrome/common/extensions/PRESUBMIT.py (right):

https://codereview.chromium.org/10993029/diff/2001/chrome/common/extensions/P...
chrome/common/extensions/PRESUBMIT.py:93: for name in
_CheckHeadingIDs(input_api))
On 2012/09/26 01:57:17, kalman wrote:
> just assign into results straight away?

Done.

https://codereview.chromium.org/10993029/diff/2001/chrome/common/extensions/d...
File chrome/common/extensions/docs/templates/articles/app_csp.html (right):

https://codereview.chromium.org/10993029/diff/2001/chrome/common/extensions/d...
chrome/common/extensions/docs/templates/articles/app_csp.html:86: <h3
id="use">Use templating libraries</h3>
On 2012/09/26 01:57:17, kalman wrote:
> People might link to these sections directly, so try to give them names that
> indicate what the content is. In this case, perhaps:
> 
> s/use/templating/

Done.

https://codereview.chromium.org/10993029/diff/2001/chrome/common/extensions/d...
chrome/common/extensions/docs/templates/articles/app_csp.html:104: <h3
id="access">Access remote resources</h3>
On 2012/09/26 01:57:17, kalman wrote:
> remote_resources

Done.

https://codereview.chromium.org/10993029/diff/2001/chrome/common/extensions/d...
File chrome/common/extensions/docs/templates/articles/app_external.html (right):

https://codereview.chromium.org/10993029/diff/2001/chrome/common/extensions/d...
chrome/common/extensions/docs/templates/articles/app_external.html:93: <h3
id="add">Add browser element</h3>
On 2012/09/26 01:57:17, kalman wrote:
> browser_element

Done.

https://codereview.chromium.org/10993029/diff/2001/chrome/common/extensions/d...
chrome/common/extensions/docs/templates/articles/app_external.html:102: <h3
id="update">Update properties</h3>
On 2012/09/26 01:57:17, kalman wrote:
> properties?

Done.

Powered by Google App Engine
This is Rietveld 408576698