Extensions Docs Server: Fix headings with no IDs

chrome/common/extensions/PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Presubmit script for changes affecting extensions.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 import fnmatch
@@ skipping 55 matching lines @@
     if (fnmatch.fnmatch(name, '%s*' % PUBLIC_TEMPLATES_PATH) or
         fnmatch.fnmatch(name, '%s*' % INTROS_PATH) or
         fnmatch.fnmatch(name, '%s*' % ARTICLES_PATH)):
       args.extend(_FindMatchingTemplates(name.split(os.sep)[-1],
                                          _ListFilesInPublic()))
     if fnmatch.fnmatch(name, '%s*' % API_PATH):
       args.extend(_FindMatchingTemplates(_SanitizeAPIName(name, API_PATH),
                                          _ListFilesInPublic()))
   return args
 
+def _CheckHeadingIDs(input_api):
+  ids_re = re.compile('<h[23].*id=.*?>')
+  headings_re = re.compile('<h[23].*?>')
+  bad_files = []
+  for name in input_api.AbsoluteLocalPaths():
+    if (fnmatch.fnmatch(name, '*%s*' % INTROS_PATH) or
+        fnmatch.fnmatch(name, '*%s*' % ARTICLES_PATH)):
+      contents = input_api.ReadFile(name)
+      if (len(re.findall(headings_re, contents)) !=
+          len(re.findall(ids_re, contents))):
+        bad_files.append(name)
+  return bad_files
+
 def _CheckChange(input_api, output_api):
   results = []
+  results.extend(
+      output_api.PresubmitError('File %s needs an id for each heading.' % name)
+      for name in _CheckHeadingIDs(input_api))

[not at google - send to devlin, 2012/09/26 01:57:17]

just assign into results straight away?

[cduvall, 2012/09/27 23:39:39]

Done.

   try:
     integration_test = []
     # From depot_tools/presubmit_canned_checks.py:529
     if input_api.platform == 'win32':
       integration_test = [input_api.python_executable]
     integration_test.append(
         os.path.join('docs', 'server2', 'integration_test.py'))
     integration_test.extend(_CreateIntegrationTestArgs(input_api.LocalPaths()))
     input_api.subprocess.check_call(integration_test,
                                     cwd=input_api.PresubmitLocalPath())
   except input_api.subprocess.CalledProcessError:
     results.append(output_api.PresubmitError('IntegrationTest failed!'))
   return results
 
 def CheckChangeOnUpload(input_api, output_api):
   return _CheckChange(input_api, output_api)
 
 def CheckChangeOnCommit(input_api, output_api):
   return _CheckChange(input_api, output_api)