Issue 10993011: Merged r12531, r12562, r12563 into 3.12 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10993011: Merged r12531, r12562, r12563 into 3.12 branch. (Closed)

Created:
8 years, 2 months ago by Jakob Kummerow

Modified:
8 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.12

Visibility:
Public.

Merged r12531, r12562, r12563 into 3.12 branch. Fix casting error for receiver of interceptors. Fix LBoundsCheck on x64 to handle (stack slot + constant) correctly Fix missing slot recodring during clearing of CallICs. BUG=chromium:149912, 150729, chromium:144230 R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12607

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -24 lines)			Patch
M	src/ic-inl.h	View		2 chunks	+10 lines, -2 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/objects.cc	View		4 chunks	+6 lines, -8 lines	0 comments	Download
M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+9 lines, -3 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1	2 chunks	+61 lines, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-150729.js	View		1 chunk	+9 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Starzinger

LGTM (reviewed all except lithium-codegen-x64.cc).

8 years, 2 months ago (2012-09-25 17:22:34 UTC) #2

Patch set 2 LGTM.