[DevTools] Migrate android to devtools_discovery.

[DevTools] Migrate android to devtools_discovery.

BUG=476496
Committed: https://crrev.com/ec2b982acd3d3b1ef7b52d9458157514144e9b25
Cr-Commit-Position: refs/heads/master@{#327258}

[dgozman, 2015-04-23 14:44:37]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2015-04-23 14:44:37]

Take a look please.

[pfeldman, 2015-04-23 14:47:49]

lgtm

[dgozman, 2015-04-23 16:27:25]

dgozman@chromium.org changed reviewers:
+ dtrainor@chromium.org, jochen@chromium.org, mnaganov@chromium.org

[dgozman, 2015-04-23 16:27:25]

Hello owners, take a look please:

jochen - at chrome/browser;
dtrainor - at chrome/browser/android;
mnaganov - at android_webview.

Thank you,
Dmitry

[mnaganov (inactive), 2015-04-23 16:28:10]

android_webview LGTM

[David Trainor- moved to gerrit, 2015-04-23 18:01:07]

chrome/browser/android lgtm.

https://codereview.chromium.org/1099243004/diff/40001/chrome/browser/android/...
File chrome/browser/android/dev_tools_discovery_provider_android.cc (right):

https://codereview.chromium.org/1099243004/diff/40001/chrome/browser/android/...
chrome/browser/android/dev_tools_discovery_provider_android.cc:54: std::string
GetParentId() const override {
Might not be in the scope of this change, but have you thought about making all
of these these "const std::string&" or "const GURL&"

https://codereview.chromium.org/1099243004/diff/40001/chrome/browser/android/...
chrome/browser/android/dev_tools_discovery_provider_android.cc:220: WebContents*
web_contents = model->GetWebContentsAt(i);
Maybe change this to tab->web_contents()?  That's what tab_model_jni_bridge
would end up doing anyway.

[dgozman, 2015-04-24 10:23:25]

https://codereview.chromium.org/1099243004/diff/40001/chrome/browser/android/...
File chrome/browser/android/dev_tools_discovery_provider_android.cc (right):

https://codereview.chromium.org/1099243004/diff/40001/chrome/browser/android/...
chrome/browser/android/dev_tools_discovery_provider_android.cc:54: std::string
GetParentId() const override {
On 2015/04/23 18:01:07, David Trainor wrote:
> Might not be in the scope of this change, but have you thought about making
all
> of these these "const std::string&" or "const GURL&"

That's interesting idea. I have to check this won't constrain all other
embedders, and if it's fine I will do a mass change across all platforms.

https://codereview.chromium.org/1099243004/diff/40001/chrome/browser/android/...
chrome/browser/android/dev_tools_discovery_provider_android.cc:220: WebContents*
web_contents = model->GetWebContentsAt(i);
On 2015/04/23 18:01:06, David Trainor wrote:
> Maybe change this to tab->web_contents()?  That's what tab_model_jni_bridge
> would end up doing anyway.

Done.

[dgozman, 2015-04-27 11:42:58]

@jochen: take a look at chrome/browser please.

[jochen (gone - plz use gerrit), 2015-04-27 19:38:57]

lgtm with question addressed

https://codereview.chromium.org/1099243004/diff/60001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/1099243004/diff/60001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.cc:521: #if defined(OS_ANDROID)
why not just inline this in PostProfileInit?

[dgozman, 2015-04-28 09:27:06]

https://codereview.chromium.org/1099243004/diff/60001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/1099243004/diff/60001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.cc:521: #if defined(OS_ANDROID)
On 2015/04/27 19:38:57, jochen wrote:
> why not just inline this in PostProfileInit?

Inlined.

[dgozman, 2015-04-28 09:27:12]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2015-04-28 09:27:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, mnaganov@chromium.org, pfeldman@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1099243004/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-04-28 09:27:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1099243004/80001

[commit-bot: I haz the power, 2015-04-28 10:36:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-28 10:37:33]

Patchset 5 (id:??) landed as
https://crrev.com/ec2b982acd3d3b1ef7b52d9458157514144e9b25
Cr-Commit-Position: refs/heads/master@{#327258}