Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: chrome/browser/chrome_browser_main.cc

Issue 1099243004: [DevTools] Migrate android to devtools_discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased, minor fix Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_browser_main.h" 5 #include "chrome/browser/chrome_browser_main.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 #include "net/cookies/cookie_monster.h" 137 #include "net/cookies/cookie_monster.h"
138 #include "net/http/http_network_layer.h" 138 #include "net/http/http_network_layer.h"
139 #include "net/http/http_stream_factory.h" 139 #include "net/http/http_stream_factory.h"
140 #include "net/url_request/url_request.h" 140 #include "net/url_request/url_request.h"
141 #include "ui/base/l10n/l10n_util.h" 141 #include "ui/base/l10n/l10n_util.h"
142 #include "ui/base/layout.h" 142 #include "ui/base/layout.h"
143 #include "ui/base/resource/resource_bundle.h" 143 #include "ui/base/resource/resource_bundle.h"
144 #include "ui/strings/grit/app_locale_settings.h" 144 #include "ui/strings/grit/app_locale_settings.h"
145 145
146 #if defined(OS_ANDROID) 146 #if defined(OS_ANDROID)
147 #include "chrome/browser/android/dev_tools_discovery_provider_android.h"
147 #include "chrome/browser/metrics/thread_watcher_android.h" 148 #include "chrome/browser/metrics/thread_watcher_android.h"
148 #else 149 #else
149 #include "chrome/browser/feedback/feedback_profile_observer.h" 150 #include "chrome/browser/feedback/feedback_profile_observer.h"
150 #endif // defined(OS_ANDROID) 151 #endif // defined(OS_ANDROID)
151 152
152 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) 153 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
153 #include "chrome/browser/first_run/upgrade_util_linux.h" 154 #include "chrome/browser/first_run/upgrade_util_linux.h"
154 #include "chrome/browser/sxs_linux.h" 155 #include "chrome/browser/sxs_linux.h"
155 #endif // defined(OS_LINUX) && !defined(OS_CHROMEOS) 156 #endif // defined(OS_LINUX) && !defined(OS_CHROMEOS)
156 157
(...skipping 352 matching lines...) Expand 10 before | Expand all | Expand 10 after
509 g_browser_process->profile_manager()->user_data_dir(); 510 g_browser_process->profile_manager()->user_data_dir();
510 base::FilePath startup_profile_dir = 511 base::FilePath startup_profile_dir =
511 GetStartupProfilePath(user_data_dir, command_line); 512 GetStartupProfilePath(user_data_dir, command_line);
512 513
513 StartupBrowserCreator::ProcessCommandLineAlreadyRunning( 514 StartupBrowserCreator::ProcessCommandLineAlreadyRunning(
514 command_line, current_directory, startup_profile_dir); 515 command_line, current_directory, startup_profile_dir);
515 return true; 516 return true;
516 } 517 }
517 #endif // !defined(OS_ANDROID) 518 #endif // !defined(OS_ANDROID)
518 519
520 void SetUpDevToolsDiscovery() {
521 #if defined(OS_ANDROID)
jochen (gone - plz use gerrit) 2015/04/27 19:38:57 why not just inline this in PostProfileInit?
dgozman 2015/04/28 09:27:06 Inlined.
522 DevToolsDiscoveryProviderAndroid::Install();
523 #endif // defined(OS_ANDROID)
524 }
525
519 void LaunchDevToolsHandlerIfNeeded(const base::CommandLine& command_line) { 526 void LaunchDevToolsHandlerIfNeeded(const base::CommandLine& command_line) {
520 if (command_line.HasSwitch(::switches::kRemoteDebuggingPort)) { 527 if (command_line.HasSwitch(::switches::kRemoteDebuggingPort)) {
521 std::string port_str = 528 std::string port_str =
522 command_line.GetSwitchValueASCII(::switches::kRemoteDebuggingPort); 529 command_line.GetSwitchValueASCII(::switches::kRemoteDebuggingPort);
523 int port; 530 int port;
524 if (base::StringToInt(port_str, &port) && port >= 0 && port < 65535) { 531 if (base::StringToInt(port_str, &port) && port >= 0 && port < 65535) {
525 g_browser_process->CreateDevToolsHttpProtocolHandler( 532 g_browser_process->CreateDevToolsHttpProtocolHandler(
526 chrome::HOST_DESKTOP_TYPE_NATIVE, 533 chrome::HOST_DESKTOP_TYPE_NATIVE,
527 "127.0.0.1", 534 "127.0.0.1",
528 static_cast<uint16>(port)); 535 static_cast<uint16>(port));
(...skipping 556 matching lines...) Expand 10 before | Expand all | Expand 10 after
1085 javascript_dialog_extensions_client::InstallClient(); 1092 javascript_dialog_extensions_client::InstallClient();
1086 #endif // defined(ENABLE_EXTENSIONS) 1093 #endif // defined(ENABLE_EXTENSIONS)
1087 1094
1088 #if !defined(OS_IOS) 1095 #if !defined(OS_IOS)
1089 InstallChromeJavaScriptNativeDialogFactory(); 1096 InstallChromeJavaScriptNativeDialogFactory();
1090 #endif // !defined(OS_IOS) 1097 #endif // !defined(OS_IOS)
1091 } 1098 }
1092 1099
1093 void ChromeBrowserMainParts::PostProfileInit() { 1100 void ChromeBrowserMainParts::PostProfileInit() {
1094 TRACE_EVENT0("startup", "ChromeBrowserMainParts::PostProfileInit"); 1101 TRACE_EVENT0("startup", "ChromeBrowserMainParts::PostProfileInit");
1102 SetUpDevToolsDiscovery();
1095 LaunchDevToolsHandlerIfNeeded(parsed_command_line()); 1103 LaunchDevToolsHandlerIfNeeded(parsed_command_line());
1096 for (size_t i = 0; i < chrome_extra_parts_.size(); ++i) 1104 for (size_t i = 0; i < chrome_extra_parts_.size(); ++i)
1097 chrome_extra_parts_[i]->PostProfileInit(); 1105 chrome_extra_parts_[i]->PostProfileInit();
1098 } 1106 }
1099 1107
1100 void ChromeBrowserMainParts::PreBrowserStart() { 1108 void ChromeBrowserMainParts::PreBrowserStart() {
1101 TRACE_EVENT0("startup", "ChromeBrowserMainParts::PreBrowserStart"); 1109 TRACE_EVENT0("startup", "ChromeBrowserMainParts::PreBrowserStart");
1102 for (size_t i = 0; i < chrome_extra_parts_.size(); ++i) 1110 for (size_t i = 0; i < chrome_extra_parts_.size(); ++i)
1103 chrome_extra_parts_[i]->PreBrowserStart(); 1111 chrome_extra_parts_[i]->PreBrowserStart();
1104 1112
(...skipping 660 matching lines...) Expand 10 before | Expand all | Expand 10 after
1765 chromeos::CrosSettings::Shutdown(); 1773 chromeos::CrosSettings::Shutdown();
1766 #endif // defined(OS_CHROMEOS) 1774 #endif // defined(OS_CHROMEOS)
1767 #endif // defined(OS_ANDROID) 1775 #endif // defined(OS_ANDROID)
1768 } 1776 }
1769 1777
1770 // Public members: 1778 // Public members:
1771 1779
1772 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) { 1780 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
1773 chrome_extra_parts_.push_back(parts); 1781 chrome_extra_parts_.push_back(parts);
1774 } 1782 }
OLDNEW
« no previous file with comments | « chrome/browser/android/dev_tools_manager_delegate_android.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698