Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 1099113002: Rename 2 SVG text tests to reflect that they are for selection (Closed)

Created:
5 years, 8 months ago by m.azam
Modified:
5 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename 2 SVG text tests to reflect that they are for selection. This patch renames the following SVG text tests because they are actually testing selection. The associated expectation files have been updated as well. 1. text-text-07-t.svg -> text-selection-text-07-t.svg 2. text-text-08-b.svg -> text-selection-text-08-b.svg BUG=477550 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194553

Patch Set 1 #

Patch Set 2 : Rename 2 SVG text tests to reflect that they are for selection. #

Patch Set 3 : Rename 2 SVG text tests to reflect that they are for selection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-14 lines, -489 lines) Patch
A + LayoutTests/platform/android/svg/text/text-selection-text-07-t-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/android/svg/text/text-selection-text-08-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/android/svg/text/text-text-07-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/android/svg/text/text-text-08-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/android/virtual/slimmingpaint/svg/text/text-selection-text-07-t-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/android/virtual/slimmingpaint/svg/text/text-selection-text-08-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/android/virtual/slimmingpaint/svg/text/text-text-07-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/android/virtual/slimmingpaint/svg/text/text-text-08-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-text-07-t-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-text-07-t-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-text-08-b-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-text-08-b-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/linux/svg/text/text-text-07-t-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/text/text-text-07-t-expected.txt View 1 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/linux/svg/text/text-text-08-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/text/text-text-08-b-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
A + LayoutTests/platform/linux/virtual/slimmingpaint/svg/text/text-selection-text-07-t-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/linux/virtual/slimmingpaint/svg/text/text-selection-text-08-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/slimmingpaint/svg/text/text-text-07-t-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/slimmingpaint/svg/text/text-text-08-b-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/mac-snowleopard/svg/text/text-selection-text-07-t-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/svg/text/text-text-07-t-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/mac-snowleopard/virtual/slimmingpaint/svg/text/text-selection-text-07-t-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/virtual/slimmingpaint/svg/text/text-text-07-t-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-text-07-t-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-text-07-t-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-text-08-b-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-text-08-b-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/mac/svg/text/text-text-07-t-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/text/text-text-07-t-expected.txt View 1 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/mac/svg/text/text-text-08-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/text/text-text-08-b-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-text-07-t-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-text-07-t-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-text-08-b-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-text-08-b-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-text-07-t-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-text-07-t-expected.txt View 1 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-text-08-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-text-08-b-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-text-07-t-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-text-07-t-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-text-08-b-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-text-08-b-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-text-07-t-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-text-07-t-expected.txt View 1 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-text-08-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-text-08-b-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-text-07-t-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-text-07-t-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-text-08-b-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-text-08-b-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-text-07-t-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-text-07-t-expected.txt View 1 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-text-08-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-text-08-b-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-text-07-t-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-text-07-t-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-text-08-b-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-text-08-b-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win/svg/text/text-text-07-t-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/win/svg/text/text-text-07-t-expected.txt View 1 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/win/svg/text/text-text-08-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/win/svg/text/text-text-08-b-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
A + LayoutTests/platform/win/virtual/slimmingpaint/svg/text/text-selection-text-07-t-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/platform/win/virtual/slimmingpaint/svg/text/text-selection-text-08-b-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/win/virtual/slimmingpaint/svg/text/text-text-07-t-expected.png View 1 2 Binary file 0 comments Download
D LayoutTests/platform/win/virtual/slimmingpaint/svg/text/text-text-08-b-expected.png View 1 2 Binary file 0 comments Download
A + LayoutTests/svg/text/text-selection-text-07-t.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/text/text-selection-text-08-b.svg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/svg/text/text-text-07-t.svg View 1 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/svg/text/text-text-08-b.svg View 1 1 chunk +0 lines, -54 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
m.azam
I have compared text and W3C-SVG-1.1 folders and found that below files are duplicate tests ...
5 years, 8 months ago (2015-04-21 13:24:10 UTC) #2
pdr.
On 2015/04/21 at 13:24:10, m.azam wrote: > I have compared text and W3C-SVG-1.1 folders and ...
5 years, 8 months ago (2015-04-24 04:00:04 UTC) #3
m.azam
On 2015/04/24 04:00:04, pdr wrote: PTAL
5 years, 8 months ago (2015-04-25 13:12:34 UTC) #4
pdr.
LGTM
5 years, 8 months ago (2015-04-26 00:55:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099113002/20001
5 years, 8 months ago (2015-04-26 00:55:23 UTC) #7
pdr.
Oops, I just noticed these tests were renamed to "text-selected-*" instead of "text-selection-*". For consistency ...
5 years, 8 months ago (2015-04-26 01:37:29 UTC) #9
m.azam
On 2015/04/26 01:37:29, pdr wrote: PTAL
5 years, 8 months ago (2015-04-27 05:10:20 UTC) #10
pdr.
lgtm
5 years, 8 months ago (2015-04-27 21:01:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099113002/40001
5 years, 8 months ago (2015-04-27 21:02:42 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 22:11:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194553

Powered by Google App Engine
This is Rietveld 408576698