Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 10991032: Revert 158707 - Enable by default: (Closed)

Created:
8 years, 2 months ago by csilv
Modified:
8 years, 2 months ago
Reviewers:
Vangelis Kokkevis
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, yoshiki+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 158707 - Enable by default: 1. threaded compositing on windows (except XP) 2. force compositing mode on mac On linux we switch to a 1/3 1/3 fcm and thread experiments . This patch also gives priority to the command line switches so that both threaded and force compositing mode can be turned off via the about:flags page or command line. In the near future, we will use the Finch framework to tweak the experiment percentages. Note: This patch has a dependency on: https://bugs.webkit.org/show_bug.cgi?id=96871 It also disables ExtensionApiTest.CaptureVisibleTabJPeg as it triggers flakiness on it. chrome.tabs.captureVisibleTab is inherently racy as there is no way to guarantee that the tab has been painted at least once when that call is made. Note how the other variants of CaptureVisibleTab tests have already been disabled for similar reasons. BUG=143809, 128387, 146861 Review URL: https://chromiumcodereview.appspot.com/10914247 Reverted due to failures on Mac bots: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/29446/steps/interactive_ui_tests/logs/AutoResize http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%281%29/builds/2143/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%283%29/builds/26358/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%283%29/builds/1804/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine TBR=vangelis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -89 lines) Patch
M chrome/browser/chrome_gpu_util.cc View 2 chunks +22 lines, -30 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 14 chunks +29 lines, -40 lines 0 comments Download
M content/common/compositor_util.cc View 2 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
csilv
8 years, 2 months ago (2012-09-26 01:55:14 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698