Added nudge source counters to about:sync.

sync/internal_api/sync_manager_impl.cc

Index: sync/internal_api/sync_manager_impl.cc
diff --git a/sync/internal_api/sync_manager_impl.cc b/sync/internal_api/sync_manager_impl.cc
index 20852f40ab391aa665dcae3a601239c71b314c88..cf28608c356d4d70f7b6f4fc3c34250c642681a8 100644
--- a/sync/internal_api/sync_manager_impl.cc
+++ b/sync/internal_api/sync_manager_impl.cc
@@ -979,10 +979,10 @@ void SyncManagerImpl::RequestNudgeForDataTypes(
   base::TimeDelta nudge_delay = NudgeStrategy::GetNudgeDelayTimeDelta(
       types.First().Get(),
       this);
-  scheduler_->ScheduleNudgeAsync(nudge_delay,
-                                 NUDGE_SOURCE_LOCAL,
-                                 types,
-                                 nudge_location);
+  ScheduleNudgeAsync(nudge_delay,
+                     NUDGE_SOURCE_LOCAL,
+                     types,
+                     nudge_location);
 }
 
 void SyncManagerImpl::OnSyncEngineEvent(const SyncEngineEvent& event) {
@@ -1273,12 +1273,12 @@ void SyncManagerImpl::OnIncomingInvalidation(
   const ModelTypeStateMap& type_state_map =
       ObjectIdStateMapToModelTypeStateMap(id_state_map);
   if (source == LOCAL_INVALIDATION) {
-    scheduler_->ScheduleNudgeWithStatesAsync(
+    ScheduleNudgeWithStatesAsync(
         TimeDelta::FromMilliseconds(kSyncRefreshDelayMsec),
         NUDGE_SOURCE_LOCAL_REFRESH,
         type_state_map, FROM_HERE);
   } else if (!type_state_map.empty()) {
-    scheduler_->ScheduleNudgeWithStatesAsync(
+    ScheduleNudgeWithStatesAsync(
         TimeDelta::FromMilliseconds(kSyncSchedulerDelayMsec),
         NUDGE_SOURCE_NOTIFICATION,
         type_state_map, FROM_HERE);
@@ -1349,6 +1349,26 @@ SyncEncryptionHandler* SyncManagerImpl::GetEncryptionHandler() {
   return sync_encryption_handler_.get();
 }
 
+void SyncManagerImpl::ScheduleNudgeAsync(
+    const base::TimeDelta& delay,

[rlarocque, 2012/09/24 23:24:37]

A TimeDelta isn't very big.  It would be cheaper to pass a copy than a const
reference.  

+    NudgeSource source,
+    ModelTypeSet types,
+    const tracked_objects::Location& nudge_location) {
+  allstatus_.IncrementNudgeCounter(source);
+  scheduler_->ScheduleNudgeAsync(delay, source,

[rlarocque, 2012/09/24 23:24:37]

nit: This style of line wrapping for parameters is discouraged.

See http://dev.chromium.org/developers/coding-style#Code_Formatting

+                                 types, nudge_location);
+}
+
+
+void SyncManagerImpl::ScheduleNudgeWithStatesAsync(
+    const base::TimeDelta& delay, NudgeSource source,
+    const ModelTypeStateMap& type_state_map,
+    const tracked_objects::Location& nudge_location) {
+  allstatus_.IncrementNudgeCounter(source);
+  scheduler_->ScheduleNudgeWithStatesAsync(delay, source,
+                                           type_state_map, nudge_location);
+}
+
 // static.
 int SyncManagerImpl::GetDefaultNudgeDelay() {
   return kDefaultNudgeDelayMilliseconds;