Added nudge source counters to about:sync.

sync/internal_api/sync_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/internal_api/sync_manager_impl.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 961 matching lines @@
 
 void SyncManagerImpl::RequestNudgeForDataTypes(
     const tracked_objects::Location& nudge_location,
     ModelTypeSet types) {
   debug_info_event_listener_.OnNudgeFromDatatype(types.First().Get());
 
   // TODO(lipalani) : Calculate the nudge delay based on all types.
   base::TimeDelta nudge_delay = NudgeStrategy::GetNudgeDelayTimeDelta(
       types.First().Get(),
       this);
-  scheduler_->ScheduleNudgeAsync(nudge_delay,
-                                 NUDGE_SOURCE_LOCAL,
-                                 types,
-                                 nudge_location);
+  ScheduleNudgeAsync(nudge_delay,
+                     NUDGE_SOURCE_LOCAL,
+                     types,
+                     nudge_location);
 }
 
 void SyncManagerImpl::OnSyncEngineEvent(const SyncEngineEvent& event) {
   DCHECK(thread_checker_.CalledOnValidThread());
   // Only send an event if this is due to a cycle ending and this cycle
   // concludes a canonical "sync" process; that is, based on what is known
   // locally we are "all happy" and up-to-date.  There may be new changes on
   // the server, but we'll get them on a subsequent sync.
   //
   // Notifications are sent at the end of every sync cycle, regardless of
@@ skipping 270 matching lines @@
   }
 }
 
 void SyncManagerImpl::OnIncomingInvalidation(
     const ObjectIdStateMap& id_state_map,
     IncomingInvalidationSource source) {
   DCHECK(thread_checker_.CalledOnValidThread());
   const ModelTypeStateMap& type_state_map =
       ObjectIdStateMapToModelTypeStateMap(id_state_map);
   if (source == LOCAL_INVALIDATION) {
-    scheduler_->ScheduleNudgeWithStatesAsync(
+    ScheduleNudgeWithStatesAsync(
         TimeDelta::FromMilliseconds(kSyncRefreshDelayMsec),
         NUDGE_SOURCE_LOCAL_REFRESH,
         type_state_map, FROM_HERE);
   } else if (!type_state_map.empty()) {
-    scheduler_->ScheduleNudgeWithStatesAsync(
+    ScheduleNudgeWithStatesAsync(
         TimeDelta::FromMilliseconds(kSyncSchedulerDelayMsec),
         NUDGE_SOURCE_NOTIFICATION,
         type_state_map, FROM_HERE);
     allstatus_.IncrementNotificationsReceived();
     UpdateNotificationInfo(type_state_map);
     debug_info_event_listener_.OnIncomingNotification(type_state_map);
   } else {
     LOG(WARNING) << "Sync received invalidation without any type information.";
   }
 
@@ skipping 50 matching lines @@
 
 bool SyncManagerImpl::HasUnsyncedItems() {
   ReadTransaction trans(FROM_HERE, GetUserShare());
   return (trans.GetWrappedTrans()->directory()->unsynced_entity_count() != 0);
 }
 
 SyncEncryptionHandler* SyncManagerImpl::GetEncryptionHandler() {
   return sync_encryption_handler_.get();
 }
 
+void SyncManagerImpl::ScheduleNudgeAsync(
+    const base::TimeDelta& delay,

[rlarocque, 2012/09/24 23:24:37]

A TimeDelta isn't very big.  It would be cheaper to pass a copy than a const
reference.  

+    NudgeSource source,
+    ModelTypeSet types,
+    const tracked_objects::Location& nudge_location) {
+  allstatus_.IncrementNudgeCounter(source);
+  scheduler_->ScheduleNudgeAsync(delay, source,

[rlarocque, 2012/09/24 23:24:37]

nit: This style of line wrapping for parameters is discouraged.

See http://dev.chromium.org/developers/coding-style#Code_Formatting

+                                 types, nudge_location);
+}
+
+
+void SyncManagerImpl::ScheduleNudgeWithStatesAsync(
+    const base::TimeDelta& delay, NudgeSource source,
+    const ModelTypeStateMap& type_state_map,
+    const tracked_objects::Location& nudge_location) {
+  allstatus_.IncrementNudgeCounter(source);
+  scheduler_->ScheduleNudgeWithStatesAsync(delay, source,
+                                           type_state_map, nudge_location);
+}
+
 // static.
 int SyncManagerImpl::GetDefaultNudgeDelay() {
   return kDefaultNudgeDelayMilliseconds;
 }
 
 // static.
 int SyncManagerImpl::GetPreferencesNudgeDelay() {
   return kPreferencesNudgeDelayMilliseconds;
 }
 
 }  // namespace syncer