Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 10990110: MIPS: Changed "marked" nops to use sll(zero_reg, at, type). (Closed)

Created:
8 years, 2 months ago by palfia
Modified:
8 years, 2 months ago
Reviewers:
kisg, Paul Lind, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Changed "marked" nops to use sll(zero_reg, at, type). We use marking bits in nops (in the 'sa' field) for debug markers, and for some IC stuff. A normal NOP in mips is sll(zero_reg, zero_reg, 0), where the 0 is a 5 bit immediate field in 'sa'. See enum NopMarkerTypes at around line 654 of assembler-mips.h The problem is that these markers use encodings that are reserved for the 'ssnop' and 'ehb' instructions. These are instructions used for hazard barriers. It does not break anything, but it will slow things down a little bit as some pipeline stages are cleared, etc. This commit changes the "marked" NOPs to sll(zero_reg, at, type) instructions, which is also a NOP operation on MIPS. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M src/mips/assembler-mips.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
palfia
8 years, 2 months ago (2012-09-28 16:49:12 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698