Issue 10990108: Handle modifiers (abstract) on class nodes.

Issue 10990108: Handle modifiers (abstract) on class nodes. (Closed)

Created:
8 years, 2 months ago by Johnni Winther

Modified:
8 years, 2 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle modifiers (abstract) on class nodes. Committed: https://code.google.com/p/dart/source/detail?r=13515

Patch Set 2 : Updated cf. comment #

Total comments: 1

Patch Set 3 : Rebased + bug fixed. #

Patch Set 4 : TODO added #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -41 lines)			Patch
M	lib/compiler/implementation/dart_backend/utils.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/scanner/class_element_parser.dart	View	1 2 3	2 chunks	+5 lines, -31 lines	0 comments	Download
M	lib/compiler/implementation/scanner/listener.dart	View	1 2	2 chunks	+7 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/scanner/parser.dart	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/tree/nodes.dart	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/unparser_test.dart	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ahe

I don't see any tests. I suggest adding at least a new test to unparser_test. ...

8 years, 2 months ago (2012-10-09 12:47:35 UTC) #3

Johnni Winther

Test added. PTAL https://codereview.chromium.org/10990108/diff/1/lib/compiler/implementation/scanner/class_element_parser.dart File lib/compiler/implementation/scanner/class_element_parser.dart (right): https://codereview.chromium.org/10990108/diff/1/lib/compiler/implementation/scanner/class_element_parser.dart#newcode61 lib/compiler/implementation/scanner/class_element_parser.dart:61: Modifiers get modifiers() => cachedNode != ...

8 years, 2 months ago (2012-10-09 14:04:57 UTC) #4

Johnni Winther

8 years, 2 months ago (2012-10-10 10:30:36 UTC) #6

https://codereview.chromium.org/10990108/diff/5001/lib/compiler/implementatio...
File lib/compiler/implementation/scanner/class_element_parser.dart (right):

https://codereview.chromium.org/10990108/diff/5001/lib/compiler/implementatio...
lib/compiler/implementation/scanner/class_element_parser.dart:59: Modifiers get
modifiers => cachedNode.modifiers;
This didn't work. Added a TODO instead.

Expand Messages | Collapse Messages