Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 10990079: Clean up scoped_com_initializer.h. Remove #ifdefs for non-Windows (this is in base/win, no one sho… (Closed)

Created:
8 years, 2 months ago by Peter Kasting
Modified:
8 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Clean up scoped_com_initializer.h, primarily by removing #ifdefs for non-Windows. Instead change files that use this to specifically #ifdef it for OS_WIN, like we do most other Windows-specific code. I plan to factor out the "subclass base::Thread to init MTA on Windows" pattern to its own file in a followup change. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159545

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -117 lines) Patch
M base/win/scoped_com_initializer.h View 4 chunks +7 lines, -40 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 1 4 chunks +9 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 3 chunks +9 lines, -7 lines 4 comments Download
M content/gpu/gpu_main.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 chunks +5 lines, -7 lines 0 comments Download
M content/test/content_test_suite.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M content/test/webrtc_audio_device_test.h View 1 3 chunks +12 lines, -7 lines 0 comments Download
M content/test/webrtc_audio_device_test.cc View 1 4 chunks +10 lines, -3 lines 0 comments Download
M media/audio/audio_input_device_unittest.cc View 1 2 3 3 chunks +9 lines, -6 lines 0 comments Download
M media/audio/audio_input_volume_unittest.cc View 1 2 2 chunks +12 lines, -5 lines 0 comments Download
M media/audio/audio_low_latency_input_output_unittest.cc View 1 2 3 chunks +13 lines, -8 lines 0 comments Download
M media/audio/audio_manager_base.h View 1 2 chunks +26 lines, -2 lines 0 comments Download
M media/audio/audio_manager_base.cc View 1 5 chunks +9 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Kasting
8 years, 2 months ago (2012-09-27 04:16:11 UTC) #1
Peter Kasting
ping
8 years, 2 months ago (2012-09-29 21:47:16 UTC) #2
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/10990079/diff/1005/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (left): http://codereview.chromium.org/10990079/diff/1005/content/browser/renderer_host/media/media_stream_manager.cc#oldcode59 content/browser/renderer_host/media/media_stream_manager.cc:59: Stop(); did you mean to remove this stop()? I ...
8 years, 2 months ago (2012-10-01 19:47:27 UTC) #3
cpu_(ooo_6.6-7.5)
I swear I made comments before from home. Maybe I used the google account and ...
8 years, 2 months ago (2012-10-01 19:55:19 UTC) #4
Peter Kasting
http://codereview.chromium.org/10990079/diff/1005/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (left): http://codereview.chromium.org/10990079/diff/1005/content/browser/renderer_host/media/media_stream_manager.cc#oldcode59 content/browser/renderer_host/media/media_stream_manager.cc:59: Stop(); On 2012/10/01 19:47:27, cpu wrote: > did you ...
8 years, 2 months ago (2012-10-01 20:23:17 UTC) #5
Peter Kasting
brettw, can you OWNERS r+?
8 years, 2 months ago (2012-10-01 20:37:09 UTC) #6
brettw
8 years, 2 months ago (2012-10-01 20:39:54 UTC) #7
lgtm rubberstamp

Powered by Google App Engine
This is Rietveld 408576698