Short term JSON eval cache

src/v8.cc

Index: src/v8.cc
===================================================================
--- src/v8.cc	(revision 12582)
+++ src/v8.cc	(working copy)
@@ -43,6 +43,7 @@
 #include "runtime-profiler.h"
 #include "serialize.h"
 #include "store-buffer.h"
+#include "compilation-cache.h"
 
 namespace v8 {
 namespace internal {
@@ -189,8 +190,10 @@
   // IdleNotification again.
   if (!FLAG_use_idle_notification) return true;
 
-  // Tell the heap that it may want to adjust.
-  return HEAP->IdleNotification(hint);
+  // Tell the heap that it may want to adjust. If the heap has nothing more
+  // to clean, we are really idle, so we can clear the short term caches.
+  return HEAP->IdleNotification(hint) &&

[ulan, 2012/09/28 14:26:23]

This concerns me. The embedder is not required to call IdleNotification. Our
heuristics should not rely on it. I think in normal Chrome browsing sessions,
IdleNotification rarely returns true. So the json eval cache will probably be
full most of the time. This could consume couple of MB in the worst case (512KB
of source + generated code for it).

+         ISOLATE->compilation_cache()->ClearShortTerm();
 }