Short term JSON eval cache

src/v8.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 25 matching lines @@
 #include "frames.h"
 #include "heap-profiler.h"
 #include "hydrogen.h"
 #include "lithium-allocator.h"
 #include "log.h"
 #include "once.h"
 #include "platform.h"
 #include "runtime-profiler.h"
 #include "serialize.h"
 #include "store-buffer.h"
+#include "compilation-cache.h"
 
 namespace v8 {
 namespace internal {
 
 V8_DECLARE_ONCE(init_once);
 
 bool V8::is_running_ = false;
 bool V8::has_been_set_up_ = false;
 bool V8::has_been_disposed_ = false;
 bool V8::has_fatal_error_ = false;
@@ skipping 126 matching lines @@
   ASSERT(isolate == Isolate::Current());
   return random_base(isolate->private_random_seed());
 }
 
 
 bool V8::IdleNotification(int hint) {
   // Returning true tells the caller that there is no need to call
   // IdleNotification again.
   if (!FLAG_use_idle_notification) return true;
 
-  // Tell the heap that it may want to adjust.
-  return HEAP->IdleNotification(hint);
+  // Tell the heap that it may want to adjust. If the heap has nothing more
+  // to clean, we are really idle, so we can clear the short term caches.
+  return HEAP->IdleNotification(hint) &&

[ulan, 2012/09/28 14:26:23]

This concerns me. The embedder is not required to call IdleNotification. Our
heuristics should not rely on it. I think in normal Chrome browsing sessions,
IdleNotification rarely returns true. So the json eval cache will probably be
full most of the time. This could consume couple of MB in the worst case (512KB
of source + generated code for it).

+         ISOLATE->compilation_cache()->ClearShortTerm();
 }
 
 
 void V8::AddCallCompletedCallback(CallCompletedCallback callback) {
   if (call_completed_callbacks_ == NULL) {  // Lazy init.
     call_completed_callbacks_ = new List<CallCompletedCallback>();
   }
   for (int i = 0; i < call_completed_callbacks_->length(); i++) {
     if (callback == call_completed_callbacks_->at(i)) return;
   }
@@ skipping 78 matching lines @@
   SetUpJSCallerSavedCodeData();
   SamplerRegistry::SetUp();
   ExternalReference::SetUp();
 }
 
 void V8::InitializeOncePerProcess() {
   CallOnce(&init_once, &InitializeOncePerProcessImpl);
 }
 
 } }  // namespace v8::internal