Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 10990076: Short term JSON eval cache

Created:
8 years, 2 months ago by Jay Conrod
Modified:
6 years, 8 months ago
Reviewers:
ulan, danno
CC:
v8-dev
Visibility:
Public.

Description

Short term JSON eval cache BUG=none TEST=none

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+533 lines, -33 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M src/compilation-cache.h View 7 chunks +33 lines, -9 lines 0 comments Download
M src/compilation-cache.cc View 5 chunks +126 lines, -16 lines 0 comments Download
M src/compiler.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/objects.h View 6 chunks +85 lines, -3 lines 0 comments Download
M src/objects.cc View 5 chunks +205 lines, -2 lines 0 comments Download
M src/objects-inl.h View 4 chunks +11 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M src/v8.cc View 2 chunks +5 lines, -2 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
ulan
High level comments first. I see that you have a run-time function to query the ...
8 years, 2 months ago (2012-09-28 14:26:22 UTC) #1
Jay Conrod
8 years, 2 months ago (2012-09-29 22:27:46 UTC) #2
We mainly focused on seeing performance improvement on Sunspider and ensuring
that other cases are at least neutral (no degradation) if there is no noticeable
improvement. Unfortunately for some of these changes we were limited to only
evaluating performance for the benchmarks.

w.r.t. IdleNotification, we need to ensure cache entries are maintained across
iterations of SunSpider in order for this to be useful. Maybe there's some other
way to tweak how caches are aged? IdleNotifications trigger a major GC after
every test in SunSpider. What do you think?

Powered by Google App Engine
This is Rietveld 408576698