 Chromium Code Reviews
 Chromium Code Reviews Issue 1098863003:
  Import Reversed adapter from Chromium and use it in v8.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 1098863003:
  Import Reversed adapter from Chromium and use it in v8.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| Index: src/compiler/register-allocator.cc | 
| diff --git a/src/compiler/register-allocator.cc b/src/compiler/register-allocator.cc | 
| index 9d745d0097f4e627707a0349f006c6073db7592d..0162640d572b27a7d6c62b294538bda0a41d276a 100644 | 
| --- a/src/compiler/register-allocator.cc | 
| +++ b/src/compiler/register-allocator.cc | 
| @@ -2,6 +2,7 @@ | 
| // Use of this source code is governed by a BSD-style license that can be | 
| // found in the LICENSE file. | 
| +#include "src/base/adapters.h" | 
| #include "src/compiler/linkage.h" | 
| #include "src/compiler/register-allocator.h" | 
| #include "src/string-stream.h" | 
| @@ -1411,9 +1412,8 @@ void RegisterAllocator::MeetRegisterConstraints() { | 
| void RegisterAllocator::ResolvePhis() { | 
| // Process the blocks in reverse order. | 
| - for (auto i = code()->instruction_blocks().rbegin(); | 
| - i != code()->instruction_blocks().rend(); ++i) { | 
| - ResolvePhis(*i); | 
| + for (auto i : base::Reversed(code()->instruction_blocks())) { | 
| 
Michael Starzinger
2015/04/20 13:11:14
nit: s/auto i/Node* node/
 
Sven Panne
2015/04/20 14:38:35
I guess you mean "Instruction* block" here. :-) Do
 | 
| + ResolvePhis(i); | 
| } | 
| } |