 Chromium Code Reviews
 Chromium Code Reviews Issue 1098863003:
  Import Reversed adapter from Chromium and use it in v8.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 1098863003:
  Import Reversed adapter from Chromium and use it in v8.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| Index: src/compiler/ppc/instruction-selector-ppc.cc | 
| diff --git a/src/compiler/ppc/instruction-selector-ppc.cc b/src/compiler/ppc/instruction-selector-ppc.cc | 
| index 19476bd86fef6e803fc30ac9613b55a4c18d42c7..32795ee65966992f037f05248adf841a00421c66 100644 | 
| --- a/src/compiler/ppc/instruction-selector-ppc.cc | 
| +++ b/src/compiler/ppc/instruction-selector-ppc.cc | 
| @@ -2,6 +2,7 @@ | 
| // Use of this source code is governed by a BSD-style license that can be | 
| // found in the LICENSE file. | 
| +#include "src/base/adapters.h" | 
| #include "src/compiler/instruction-selector-impl.h" | 
| #include "src/compiler/node-matchers.h" | 
| #include "src/compiler/node-properties.h" | 
| @@ -1453,9 +1454,8 @@ void InstructionSelector::VisitCall(Node* node, BasicBlock* handler) { | 
| // Push any stack arguments. | 
| // TODO(mbrandy): reverse order and use push only for first | 
| - for (auto i = buffer.pushed_nodes.rbegin(); i != buffer.pushed_nodes.rend(); | 
| - i++) { | 
| - Emit(kPPC_Push, g.NoOutput(), g.UseRegister(*i)); | 
| + for (auto i : base::Reversed(buffer.pushed_nodes)) { | 
| 
Michael Starzinger
2015/04/20 13:11:14
nit: s/auto i/Node* node/
 
Sven Panne
2015/04/20 14:38:35
Done.
 | 
| + Emit(kPPC_Push, g.NoOutput(), g.UseRegister(i)); | 
| } | 
| // Pass label of exception handler block. |