Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 10987051: roll gyp 1501:1507 (Closed)

Created:
8 years, 2 months ago by Torne
Modified:
8 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

roll gyp 1501:1507 r1503 Ensure that all entries in .sln files are sorted. r1504 Adding a test to cover XCode UID collisions. r1505 Allow library entries of the form '-lfoo' on MSVS. r1506 Correct dump_dependency_json on windows. r1507 make: drop all system tests R=thakis@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Torne
Running trys now to see if anything explodes.
8 years, 2 months ago (2012-09-26 14:20:37 UTC) #1
Nico
You're missing r1502 in the CL description. On Wed, Sep 26, 2012 at 11:20 PM, ...
8 years, 2 months ago (2012-09-26 14:50:45 UTC) #2
Torne
There isn't an r1502 in /trunk, so it didn't come up when I did svn ...
8 years, 2 months ago (2012-09-26 14:53:40 UTC) #3
Nico
lgtm On Wed, Sep 26, 2012 at 11:53 PM, <torne@chromium.org> wrote: > There isn't an ...
8 years, 2 months ago (2012-09-26 15:02:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/10987051/1
8 years, 2 months ago (2012-09-26 16:04:29 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 19:59:03 UTC) #6
Change committed as 158862

Powered by Google App Engine
This is Rietveld 408576698