Move the symbolization code to tools/valgrind/asan/asan_symbolize_trunk.py (it's now a copy of the …

Move the symbolization code to tools/valgrind/asan/third_party/asan_symbolize.py (it's now a copy of the upstream asan_symbolize.py)
asan_symbolize.py (the name is kept for compatibility reasons) is now a tiny wrapper that runs the symbolizer with some Chrome-specific code injected.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159019

[Alexander Potapenko, 2012-09-26 13:39:34]

Marc-Antoine, can you please review this?
I'm not sure if this is a correct thing to do in the case we're copying 3rd
party python code. Adding some nested third_party/ dir will require an
additional __init__.py file.

Abhishek, this is FYI. I hope this change should not affect CF. It should bring
the support for LLDB-based symbolizer written by Alexey recently.

[aarya, 2012-09-26 15:08:58]

On 2012/09/26 13:39:34, Alexander Potapenko wrote:
> Marc-Antoine, can you please review this?
> I'm not sure if this is a correct thing to do in the case we're copying 3rd
> party python code. Adding some nested third_party/ dir will require an
> additional __init__.py file.
> 
> Abhishek, this is FYI. I hope this change should not affect CF. It should
bring
> the support for LLDB-based symbolizer written by Alexey recently.

Yes not worrisome on ClusterFuzz since we don't use asan_symbolize.py but a
custom variant of it in our source directory. I do need to migrate the code at
some point, probably after pwnium.

[M-A Ruel, 2012-09-26 16:58:29]

On 2012/09/26 13:39:34, Alexander Potapenko wrote:
> Marc-Antoine, can you please review this?
> I'm not sure if this is a correct thing to do in the case we're copying 3rd
> party python code. Adding some nested third_party/ dir will require an
> additional __init__.py file.

It'd still be preferable to put that in a third_party subdirectory.

https://codereview.chromium.org/10987049/diff/1/tools/valgrind/asan/asan_symb...
File tools/valgrind/asan/asan_symbolize.py (right):

https://codereview.chromium.org/10987049/diff/1/tools/valgrind/asan/asan_symb...
tools/valgrind/asan/asan_symbolize.py:20: loop =
SymbolizationLoop(binary_name_filter=fix_filename)
still prefer a main() function.

[Alexander Potapenko, 2012-09-27 10:29:08]

PTAL

[M-A Ruel, 2012-09-27 12:10:15]

lgtm, thanks