Issue 10987047: Remove WebContentsDelegate::ExecuteContextMenuCommand since it's not called by content. Since it's …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10987047: Remove WebContentsDelegate::ExecuteContextMenuCommand since it's not called by content. Since it's … (Closed)

Created:
8 years, 2 months ago by jam

Modified:
8 years, 2 months ago

Reviewers:
ananta

CC:
chromium-reviews, kkania, tfarina, joi+watch-content_chromium.org, darin-cc_chromium.org, robertshield

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove WebContentsDelegate::ExecuteContextMenuCommand since it's not called by content. Since it's only used for ChromeFrame, move it to the ExternalTabContainer interface instead. Also remove WebContentsDelegate::GetFrameNativeWindow which isn't used. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158861

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : also GetFrameNativeWindow #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -56 lines)			Patch
M	chrome/browser/automation/automation_provider_win.cc	View		1 chunk	+2 lines, -16 lines	0 comments	Download
M	chrome/browser/external_tab/external_tab_container.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/external_tab_container_win.h	View	1 2	3 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/external_tab_container_win.cc	View	1 2	3 chunks	+20 lines, -24 lines	0 comments	Download
M	content/public/browser/web_contents_delegate.h	View	1 2	2 chunks	+0 lines, -6 lines	0 comments	Download
M	content/public/browser/web_contents_delegate.cc	View	1 2	2 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages