Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3953)

Unified Diff: chrome/browser/ui/views/external_tab_container_win.cc

Issue 10987047: Remove WebContentsDelegate::ExecuteContextMenuCommand since it's not called by content. Since it's … (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: also GetFrameNativeWindow Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/external_tab_container_win.cc
===================================================================
--- chrome/browser/ui/views/external_tab_container_win.cc (revision 158727)
+++ chrome/browser/ui/views/external_tab_container_win.cc (working copy)
@@ -331,6 +331,26 @@
return tab_handle_;
}
+bool ExternalTabContainerWin::ExecuteContextMenuCommand(int command) {
+ if (!external_context_menu_.get()) {
+ NOTREACHED();
+ return false;
+ }
+
+ switch (command) {
+ case IDS_CONTENT_CONTEXT_SAVEAUDIOAS:
+ case IDS_CONTENT_CONTEXT_SAVEVIDEOAS:
+ case IDS_CONTENT_CONTEXT_SAVEIMAGEAS:
+ case IDS_CONTENT_CONTEXT_SAVELINKAS: {
+ NOTREACHED(); // Should be handled in host.
+ break;
+ }
+ }
+
+ external_context_menu_->ExecuteCommand(command);
+ return true;
+}
+
void ExternalTabContainerWin::RunUnloadHandlers(IPC::Message* reply_message) {
if (!automation_) {
delete reply_message;
@@ -595,10 +615,6 @@
void ExternalTabContainerWin::ContentsZoomChange(bool zoom_in) {
}
-gfx::NativeWindow ExternalTabContainerWin::GetFrameNativeWindow() {
- return GetNativeView();
-}
-
bool ExternalTabContainerWin::TakeFocus(content::WebContents* source,
bool reverse) {
if (automation_) {
@@ -711,26 +727,6 @@
return true;
}
-bool ExternalTabContainerWin::ExecuteContextMenuCommand(int command) {
- if (!external_context_menu_.get()) {
- NOTREACHED();
- return false;
- }
-
- switch (command) {
- case IDS_CONTENT_CONTEXT_SAVEAUDIOAS:
- case IDS_CONTENT_CONTEXT_SAVEVIDEOAS:
- case IDS_CONTENT_CONTEXT_SAVEIMAGEAS:
- case IDS_CONTENT_CONTEXT_SAVELINKAS: {
- NOTREACHED(); // Should be handled in host.
- break;
- }
- }
-
- external_context_menu_->ExecuteCommand(command);
- return true;
-}
-
bool ExternalTabContainerWin::PreHandleKeyboardEvent(
content::WebContents* source,
const NativeWebKeyboardEvent& event,
« no previous file with comments | « chrome/browser/ui/views/external_tab_container_win.h ('k') | content/public/browser/web_contents_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698