Fix CPM casting issue; refactor renderer crash events

chrome/browser/performance_monitor/performance_monitor_util.cc

Index: chrome/browser/performance_monitor/performance_monitor_util.cc
diff --git a/chrome/browser/performance_monitor/performance_monitor_util.cc b/chrome/browser/performance_monitor/performance_monitor_util.cc
index 505381fa33e791cf995885fe844bf5c60f8c6abb..59b40a0a308257b08d423fdcb438e43f722e1315 100644
--- a/chrome/browser/performance_monitor/performance_monitor_util.cc
+++ b/chrome/browser/performance_monitor/performance_monitor_util.cc
@@ -48,22 +48,14 @@ scoped_ptr<Event> CreateExtensionEvent(const EventType type,
       type, time, value.Pass()));
 }
 
-scoped_ptr<Event> CreateRendererFreezeEvent(const base::Time& time,
-                                            const std::string& url) {
-  events::RendererFreeze event;
-  event.event_type = EVENT_RENDERER_FREEZE;
-  event.time = static_cast<double>(time.ToInternalValue());
-  event.url = url;
-  scoped_ptr<base::DictionaryValue> value = event.ToValue();
-  return scoped_ptr<Event>(new Event(
-      EVENT_RENDERER_FREEZE, time, value.Pass()));
-}
-
-scoped_ptr<Event> CreateCrashEvent(const base::Time& time,
-                                   const EventType& type) {
-  events::RendererCrash event;
+scoped_ptr<Event> CreateRendererFailureEvent(const base::Time& time,
+                                             const EventType& type,
+                                             const std::string& url) {
+  events::RendererFailure event;
   event.event_type = type;
   event.time = static_cast<double>(time.ToInternalValue());
+  event.url = url;
+  LOG(WARNING) << "URL: " << url;

[Yoyo Zhou, 2012/09/29 01:19:25]

Won't this be spammy? Plus it's getting logged as an event anyway.

[Devlin, 2012/10/02 23:34:32]

Whoops; that wasn't supposed to stay in....

   scoped_ptr<base::DictionaryValue> value = event.ToValue();
   return scoped_ptr<Event>(new Event(type, time, value.Pass()));
 }