Fix CPM casting issue; refactor renderer crash events

chrome/browser/performance_monitor/performance_monitor_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/performance_monitor/performance_monitor_util.h"
 
 #include "base/json/json_writer.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_number_conversions.h"
 #include "base/threading/sequenced_worker_pool.h"
@@ skipping 30 matching lines @@
   event.extension_name = name;
   event.extension_url = url;
   event.extension_location = location;
   event.extension_version = version;
   event.extension_description = description;
   scoped_ptr<base::DictionaryValue> value = event.ToValue();
   return scoped_ptr<Event>(new Event(
       type, time, value.Pass()));
 }
 
-scoped_ptr<Event> CreateRendererFreezeEvent(const base::Time& time,
-                                            const std::string& url) {
-  events::RendererFreeze event;
-  event.event_type = EVENT_RENDERER_FREEZE;
+scoped_ptr<Event> CreateRendererFailureEvent(const base::Time& time,
+                                             const EventType& type,
+                                             const std::string& url) {
+  events::RendererFailure event;
+  event.event_type = type;
   event.time = static_cast<double>(time.ToInternalValue());
   event.url = url;
-  scoped_ptr<base::DictionaryValue> value = event.ToValue();
-  return scoped_ptr<Event>(new Event(
-      EVENT_RENDERER_FREEZE, time, value.Pass()));
-}
-
-scoped_ptr<Event> CreateCrashEvent(const base::Time& time,
-                                   const EventType& type) {
-  events::RendererCrash event;
-  event.event_type = type;
-  event.time = static_cast<double>(time.ToInternalValue());
+  LOG(WARNING) << "URL: " << url;

[Yoyo Zhou, 2012/09/29 01:19:25]

Won't this be spammy? Plus it's getting logged as an event anyway.

[Devlin, 2012/10/02 23:34:32]

Whoops; that wasn't supposed to stay in....

   scoped_ptr<base::DictionaryValue> value = event.ToValue();
   return scoped_ptr<Event>(new Event(type, time, value.Pass()));
 }
 
 scoped_ptr<Event> CreateUncleanExitEvent(const base::Time& time,
                                          const std::string& profile_name) {
   events::UncleanExit event;
   event.event_type = EVENT_UNCLEAN_EXIT;
   event.time = static_cast<double>(time.ToInternalValue());
   event.profile_name = profile_name;
@@ skipping 10 matching lines @@
   event.time = static_cast<double>(time.ToInternalValue());
   event.previous_version = previous_version;
   event.current_version = current_version;
   scoped_ptr<base::DictionaryValue> value = event.ToValue();
   return scoped_ptr<Event>(new Event(
       EVENT_CHROME_UPDATE, time, value.Pass()));
 }
 
 }  // namespace util
 }  // namespace performance_monitor