Index: chrome/browser/performance_monitor/metric.h |
diff --git a/chrome/browser/performance_monitor/metric.h b/chrome/browser/performance_monitor/metric.h |
index 76e8ded8d814ad2b38fdf90daa6780a84e35745a..5bbe270d23db1d3f3a7d5e91322a2b01d30d437a 100644 |
--- a/chrome/browser/performance_monitor/metric.h |
+++ b/chrome/browser/performance_monitor/metric.h |
@@ -17,16 +17,29 @@ namespace performance_monitor { |
// - Add the appropriate functions in |
// chrome/browser/ui/webui/performance_monitor/performance_monitor_l10n.h. |
enum MetricType { |
-METRIC_UNDEFINED, |
-METRIC_CPU_USAGE, |
-METRIC_PRIVATE_MEMORY_USAGE, |
-METRIC_SHARED_MEMORY_USAGE, |
-METRIC_STARTUP_TIME, |
-METRIC_TEST_STARTUP_TIME, |
-METRIC_SESSION_RESTORE_TIME, |
-METRIC_PAGE_LOAD_TIME, |
-METRIC_NETWORK_BYTES_READ, |
-METRIC_NUMBER_OF_METRICS |
+ // Used only to indicate invalid metrics and to generate database keys. |
Yoyo Zhou
2012/09/27 19:18:27
ditto
Devlin
2012/09/28 02:33:23
Done.
|
+ METRIC_UNDEFINED, |
+ |
+ // CPU and memory usage are combined for all Chrome-related processes. |
+ METRIC_CPU_USAGE, |
+ METRIC_PRIVATE_MEMORY_USAGE, |
+ METRIC_SHARED_MEMORY_USAGE, |
+ |
+ // Timing measurements; these are all independent metrics (e.g., session |
+ // restore time is independent of startup time, even though they may happen |
+ // in sequence). Test startup time refers to startup times which are not the |
Yoyo Zhou
2012/09/27 19:18:27
I'd write "refers to non-normal startups, e.g."
Devlin
2012/09/28 02:33:23
Done.
|
+ // norm, e.g. when we run test suites. |
+ METRIC_STARTUP_TIME, |
+ METRIC_TEST_STARTUP_TIME, |
+ METRIC_SESSION_RESTORE_TIME, |
+ METRIC_PAGE_LOAD_TIME, |
+ |
+ // Total number of bytes read since PerformanceMonitor first started running. |
+ METRIC_NETWORK_BYTES_READ, |
+ |
+ // Used only to indicate the number of metrics (including the undefined type) |
Yoyo Zhou
2012/09/27 19:18:27
ditto
Devlin
2012/09/28 02:33:23
Done.
|
+ // and to generate database keys. |
+ METRIC_NUMBER_OF_METRICS |
}; |
struct Metric { |