Fix CPM casting issue; refactor renderer crash events

chrome/browser/performance_monitor/event.h

Index: chrome/browser/performance_monitor/event.h
diff --git a/chrome/browser/performance_monitor/event.h b/chrome/browser/performance_monitor/event.h
index c2c266b5ff57f250d87e0675d987a3fb1cb4947a..8045cc07411f1c960c45f647792a724db34b417e 100644
--- a/chrome/browser/performance_monitor/event.h
+++ b/chrome/browser/performance_monitor/event.h
@@ -18,17 +18,31 @@ namespace performance_monitor {
 // - Add the appropriate functions in
 //   chrome/browser/ui/webui/performance_monitor/performance_monitor_l10n.h.
 enum EventType {
+  // Used only to indicate invalid events and to generate database keys.

[Yoyo Zhou, 2012/09/27 19:18:27]

I don't think this is needed.

[Devlin, 2012/09/28 02:33:23]

Done.

   EVENT_UNDEFINED,
+
+  // Extension-Related events
   EVENT_EXTENSION_INSTALL,
   EVENT_EXTENSION_UNINSTALL,
   EVENT_EXTENSION_UPDATE,
   EVENT_EXTENSION_ENABLE,
   EVENT_EXTENSION_DISABLE,
+
+  // Chrome's version has changed.
   EVENT_CHROME_UPDATE,
-  EVENT_RENDERER_FREEZE,
+
+  // Renderer-Failure related events; these correspond to the RENDERER_HANG
+  // event, and the two termination statuses ABNORMAL_EXIT and PROCESS_KILLED,
+  // respectively.
+  EVENT_RENDERER_HANG,
   EVENT_RENDERER_CRASH,
-  EVENT_KILLED_BY_OS_CRASH,
+  EVENT_RENDERER_KILLED,
+
+  // Chrome did not shut down correctly.
   EVENT_UNCLEAN_EXIT,
+
+  // Used only to indicate the number of events (including the undefined type)

[Yoyo Zhou, 2012/09/27 19:18:27]

I don't think you need this comment.

[Devlin, 2012/09/28 02:33:23]

Done.

+  // and to generate database keys.
   EVENT_NUMBER_OF_EVENTS
 };