Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 10987016: Fix Clang warning about tautological compare. (Closed)

Created:
8 years, 2 months ago by hans
Modified:
8 years, 2 months ago
Reviewers:
ulan_google, ulan, danno
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Fix Clang warning about tautological compare. The warning looks like this: /usr/local/google/work/chrome/src/v8/src/utils.h:977:20: warning: comparison of constant 32 with expression of type 'v8::internal::AstPropertiesFlag' is always true [-Wtautological-constant-out-of-range-compare] ASSERT(element < static_cast<int>(sizeof(T) * CHAR_BIT)); ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Work around it by casting element to int. BUG=crbug.com/151927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/utils.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hans
Wasn't sure who to put as reviewer on this, so please reassign as appropriate. This ...
8 years, 2 months ago (2012-09-25 12:33:12 UTC) #1
hans
danno: maybe you can take a look / refer me to someone who can?
8 years, 2 months ago (2012-09-26 14:10:51 UTC) #2
ulan
Sorry, I was out of office yesterday. The patch LGTM, but the base URL of ...
8 years, 2 months ago (2012-09-26 14:21:49 UTC) #3
hans
On 2012/09/26 14:21:49, ulan wrote: > The patch LGTM, but the base URL of the ...
8 years, 2 months ago (2012-09-26 14:25:56 UTC) #4
ulan
On 2012/09/26 14:25:56, hans wrote: > On 2012/09/26 14:21:49, ulan wrote: > > > The ...
8 years, 2 months ago (2012-09-26 14:29:56 UTC) #5
hans
On 2012/09/26 14:29:56, ulan wrote: > On 2012/09/26 14:25:56, hans wrote: > > On 2012/09/26 ...
8 years, 2 months ago (2012-09-26 14:32:27 UTC) #6
ulan
8 years, 2 months ago (2012-09-26 14:37:03 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698